Skip to content

fix(startup): 启动屏障测试补显式断言 - #493

Merged
AlianBlank merged 1 commit into
mainfrom
feature/auto-server-source-worker-run-7773-20260922T0640
Sep 22, 2026
Merged

AlianBlank merged 1 commit into
mainfrom
feature/auto-server-source-worker-run-7773-20260922T0640

Conversation

@AlianBlank

Copy link
Copy Markdown
Collaborator

Linear: GFX-855

StartHostsInOrderAsync_RoleExitsBeforeReady_ReleasesBarrier 原先只靠
两个 await 的超时副作用隐式验证屏障放行,无任何 Assert,触发 Sonar
S2699 BLOCKER。收尾改为接收 StartHostsInOrderAsync 返回的运行任务
列表并断言 Count 为 2,与相邻屏障用例同款;屏障死锁路径仍由既有
5 秒超时窗口覆盖,生产代码零改动。

Linear: GFX-855
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 14f2562c-1217-449d-beb2-89c7a8ac2918

📥 Commits

Reviewing files that changed from the base of the PR and between cc8241d and 95ddd48.

📒 Files selected for processing (1)
  • Tests/GameFrameX.Tests/StartUp/AppEnterShutdownOrderTests.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@AlianBlank
AlianBlank merged commit bdda090 into main Sep 22, 2026
3 checks passed
@AlianBlank
AlianBlank deleted the feature/auto-server-source-worker-run-7773-20260922T0640 branch September 22, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant