Skip to content

[Reviewed] [3D light] Spot light and point light objects#2075

Draft
D8H wants to merge 22 commits intomainfrom
3d-spot-light
Draft

[Reviewed] [3D light] Spot light and point light objects#2075
D8H wants to merge 22 commits intomainfrom
3d-spot-light

Conversation

@D8H
Copy link
Copy Markdown
Contributor

@D8H D8H commented Mar 31, 2026

@D8H D8H self-assigned this Mar 31, 2026
@D8H D8H added the ✨ New extension A new extension label Mar 31, 2026
@D8H D8H requested a review from a team as a code owner March 31, 2026 08:37
@D8H D8H added the 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. label Mar 31, 2026
@github-project-automation github-project-automation bot moved this to Needs review in Extensions review Mar 31, 2026
@D8H D8H requested a review from a team as a code owner March 31, 2026 11:05
@GDevelopApp GDevelopApp deleted a comment from github-actions bot Mar 31, 2026
@GDevelopApp GDevelopApp deleted a comment from github-actions bot Mar 31, 2026
@D8H D8H marked this pull request as draft March 31, 2026 17:15
@GDevelopApp GDevelopApp deleted a comment from github-actions bot Apr 1, 2026
@GDevelopApp GDevelopApp deleted a comment from github-actions bot Apr 1, 2026
@GDevelopApp GDevelopApp deleted a comment from github-actions bot Apr 1, 2026
@GDevelopApp GDevelopApp deleted a comment from github-actions bot Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Errors were detected in this submission:

❌ 1 Error found in extension 'Light3D':

  ⟶ ❌ [JavaScript disallowed properties]: JavaScript usage of the extension 'Light3D' must be checked by the reviewer:
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw',
    '__spotLight3DExtension',
    '__pointLight3DExtension',
    'getScene',
    '__spotLightManager',
    '__pointLightManager'
  ],
  disallowedProperty: '__lightManager',
  objectName: 'runtimeScene'
}


❌ 1 Error found in extensions - please fix it before generating the registry.
No fatal error found the extension can be updated but still need fixes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Errors were detected in this submission:

❌ 1 Error found in extension 'Light3D':

  ⟶ ❌ [JavaScript disallowed properties]: JavaScript usage of the extension 'Light3D' must be checked by the reviewer:
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw',
    '__spotLight3DExtension',
    '__pointLight3DExtension',
    'getScene',
    '__spotLightManager',
    '__pointLightManager'
  ],
  disallowedProperty: '__lightManager',
  objectName: 'runtimeScene'
}


❌ 1 Error found in extensions - please fix it before generating the registry.
No fatal error found the extension can be updated but still need fixes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Errors were detected in this submission:

❌ 1 Error found in extension 'Light3D':

  ⟶ ❌ [JavaScript disallowed properties]: JavaScript usage of the extension 'Light3D' must be checked by the reviewer:
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw',
    '__spotLight3DExtension',
    '__pointLight3DExtension',
    'getScene',
    '__spotLightManager',
    '__pointLightManager'
  ],
  disallowedProperty: '__lightManager',
  objectName: 'runtimeScene'
}


❌ 1 Error found in extensions - please fix it before generating the registry.
No fatal error found the extension can be updated but still need fixes.

@D8H D8H changed the title [Reviewed] [3D spot light] Light up a cone like a flashlight [Reviewed] [3D light] Spot light and point light objects Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ New extension A new extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging.

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

2 participants