Fix the case of the GetURLParam expression
#2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@erikdubbelboer Hi! FYI, we're making a small change to the Poki extension to use "URLParam" instead of "GetURLParam" (expressions in GDevelop are always supposed to be getters and skip the "Get" prefix). I missed this during my last review. Unrelated but I see your documentation list other game engines. As it's an "official GDevelop binding" for your SDK, do you think GDevelop could be included? A simple page explaining that this extension is available would work well + link to the generated doc if you wish: https://wiki.gdevelop.io/gdevelop5/extensions/poki-games-sdkhtml/ |
Contributor
|
@4ian good idea, I'll make sure it gets included in there soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.