Repository navigation
fix(search): format diagnostic panel as a popover to prevent footer overlap - #3634
Merged
GCWing merged 3 commits intoOct 31, 2026
Merged
Conversation
…verlap When search source diagnostics are expanded in the footer, the content previously overflowed and vertically centered over the healthy results due to footer flex sizing and lack of an elevated background. Render the diagnostics as an absolute popover panel positioned above the footer summary, styled with raised background, subtle border and overlay shadow. Add escape and click-outside handling to close the panel cleanly. Fixes GCWing#3628
The theme color audit contract rejects `var(--token, fallback)` usages whose tokens are not registered with a fallback boundary contract. The new diagnostic popover introduced five such fallbacks, failing `theme:color-audit:test`. Use the canonical tokens directly. `--openbitfun-type-body-line-height` does not exist in the design tokens, so pair the copy with `--openbitfun-type-body-sm-line-height` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search Everything source diagnostics used to expand inside a fixed-height footer, causing diagnostic text to overlap healthy search results. Show those details in a bounded, scrollable popover above the footer instead. Fixes #3628.
@openbitfun/uiPortal with its trigger as owner. The overlay coordinator owns stacking, Escape, and outside-pointer dismissal.Validation
pnpm run check:web: passed, including typography, Appearance contracts, all 28 color-audit surfaces, theme visual contracts and TypeScript.pnpm --dir src/web-ui run icons:check: passed.git diff --check: passed.The DOM tests use the production search Dialog and overlay coordinator. They cover successive Escape dismissal from the diagnostics and query field, IME Escape, focus return and modal focus ownership, outside clicks, group-detail dismissal, viewport positioning, retry and simulated Peer device changes.
Scope and verification limits
No search-provider, transport, persisted-data or wire-contract changes. Remote checks are simulated Peer identity switches and remote-looking diagnostic fixtures; live SSH workspaces, Remote Control, Peer Device connections and Detached Dispatch were not exercised. Native visual rendering was not verified with browser or computer automation.
AI-assisted implementation and tests with Codex.