Repository navigation
fix(models): correct provider editor defaults, drafts, and navigation - #3617
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom provider setup now opens with an empty API URL and a stable custom-configuration title. New editors compare editable values against their initial state, so cancelling an untouched or reverted form does not prompt to keep a draft. Cancelling or discarding new API provider setup returns to provider selection with its search and expansion state preserved and keyboard focus restored to the original provider.
The editor sizes to its content, places connection labels above their controls, and uses filled fields with standard thin borders. Model-detail actions use the existing localized Save label, and draft-confirmation actions fit in English, Simplified Chinese, and Traditional Chinese.
Type and Areas
Bug fix / UI/UX. Web UI model settings and shared design-system field surfaces.
Motivation / Impact
Verification
node scripts/run-vitest.mjs run src/app/scenes/settings/pages/ai/ModelSettingsPage.loading.test.tsx src/infrastructure/config/components/ModelSettingsDialog.presentation.test.ts src/app/scenes/settings/pages/ai/ModelSettingsPage.presentation.test.ts src/infrastructure/config/components/modelEditorRequestSettings.test.ts src/infrastructure/config/components/modelConnectionTestPlan.test.ts(fromsrc/web-ui) — 70 tests passed.node --test design-system/packages/ui/tests/field-group.test.mjs design-system/packages/ui/tests/select.test.mjs design-system/packages/ui/tests/registry.test.mjs— 11 tests passed.pnpm run check:web— passed, including type checking and Appearance/theme audits.pnpm run i18n:audit— passed.Reviewer Notes
Latest upstream main and relevant open PRs were inspected before fixing these paths; neither covered these scenarios. No persisted shape, host API, or remote protocol changes. SSH workspaces, relay/mobile control, Peer Device Mode, and Detached Dispatch were not exercised live.
Checklist