Repository navigation
fix(web-ui): clear assistant highlight when a child session is selected - #3611
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selecting a session in an assistant's expanded history highlighted both the session and its parent assistant. Apply the existing project-workspace selection styles to assistants so the visible session owns the highlight, including while hovering the parent row. Restore the assistant highlight when its history is collapsed.
Type and Areas
Type: Bug fix / UI
Areas: Web UI sidebar styling
Motivation / Impact
Assistant rows now follow the same nested-selection behavior as ordinary workspace rows. Parent background, label emphasis, and icon color no longer compete with the selected child session.
Refreshed upstream
mainand inspected related open PRs, including drafts, before editing; no existing fix covered this missing assistant style rule.Verification
pnpm run check:web— passed, including type-check and Appearance/theme governance checks.pnpm --dir src/web-ui run test:run src/app/components/NavPanel/sections/workspaces/WorkspaceListSectionLayout.test.ts src/app/components/NavPanel/sections/workspaces/AssistantSessionHistory.test.tsx src/app/components/NavPanel/sections/workspaces/assistantSessionPreferences.test.ts— 19 tests passed.git diff --check— passed.Reviewer Notes
AI-assisted; lightly tested. Browser verification used an isolated markup fixture, not the native application. Remote Workspace, Remote Control, Peer Device Mode, and Detached Dispatch were not exercised. This change only extends existing CSS selectors; it adds no runtime, persistence, or protocol changes.
Checklist