refactor: add runtime owner boundaries#978
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-runtime-ports, while keepingbitfun-services-integrations::remote_connectcompatibility re-exports for existing callers.bitfun-agent-runtimeas the first real Agent Runtime SDK owner crate for scheduler/background-delivery pure decisions; concrete scheduler/session lifecycle remains inbitfun-core.Design / behavior impact
bitfun-agent-runtimecurrently owns only background delivery decision facts. Session manager, prompt loop, subagent registry, post-turn hooks, and concrete scheduler lifecycle are explicitly still not migrated.bitfun-agent-runtimeas an actual owner crate, but only for the narrow decision surface introduced here.Verification
cargo test -p bitfun-runtime-ports remote_cargo test -p bitfun-runtime-servicescargo test -p bitfun-agent-runtimecargo test -p bitfun-services-integrations --features remote-connect --test remote_connect_contracts remote_connect_filecargo test -p bitfun-services-integrations --features remote-connect --test remote_connect_contracts remote_connect_workspace_response_helpers_own_wire_shapecargo test -p bitfun-core --features product-full cancelled_reply_is_skipped_only_when_suppressednode scripts/check-core-boundaries.mjspnpm run check:repo-hygienegit diff --check gcwing/main...HEADcargo check --workspace(passed with existingparse_clipboard_path_segmentsdead_code warning inbitfun-desktop)Frontend Build, Rust checks on Windows, Ubuntu, and macOS)Relates to #970. This PR does not close the architecture migration issue.