refactor(i18n): harden locale debt governance#977
Merged
limityan merged 1 commit intoMay 30, 2026
Conversation
670be89 to
a3c966b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the next i18n governance cleanup pass into one fork PR:
defaultValuefallbacks and direct locale-formatting calls;Intl.*/toLocale*usage outside shared i18n formatting helpers;shared.tools.searchand removes local copies;zh-TWinstaller/mobile strings where Simplified Chinese copy was still used;AGENTS.md,CONTRIBUTING.md, and durable i18n docs.Related: #959
Key Metrics
defaultValuefallbacksNotes For Reviewers
sharedis still explicit, not a global fallback namespace.defaultValuestrings are for static keys thati18n:auditverifies exist.new Intl.*, bareIntl.*, andtoLocale*call sites outside approved i18n formatting helpers.react-i18nextmocks.Risk / Behavior Changes
i18nService/useI18ninstead of browser/defaultIntlbehavior.zh-TWinstaller/mobile wording changes are visible copy improvements; they do not change resource shape or placeholders.lint:webexits 0 but still reports two pre-existing warnings insrc/web-ui/src/shared/utils/startupTrace.tsabout unusedeslint-disabledirectives.Verification
a3c966bf: Frontend Build, Rust Build Check (ubuntu-latest), Rust Build Check (macos-15), Rust Build Check (windows-latest)pnpm run i18n:contract:testpnpm run i18n:auditpnpm run i18n:audit -- --report-json <temp>pnpm --dir src/web-ui run test:run(157 files / 802 tests)pnpm run type-check:webpnpm run lint:web(exit 0; two existing warnings noted above)pnpm --dir src/mobile-web run type-checkpnpm run build:webpnpm run build:mobile-webpnpm run check:repo-hygienepnpm run check:github-configgit diff --check gcwing/main..HEAD