Skip to content

fix(debug-log): prevent ingest route startup panic#956

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/fix-debug-log-ingest-panic
May 30, 2026
Merged

fix(debug-log): prevent ingest route startup panic#956
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/fix-debug-log-ingest-panic

Conversation

@limityan
Copy link
Copy Markdown
Collaborator

Summary

  • update the debug log ingest route to axum's {session_id} path parameter syntax
  • add a regression test that starts the ingest server and catches router-construction panics

Root cause

Axum rejects route segments starting with :. The debug ingest server still registered /ingest/:session_id, so debug-mode startup could panic while building the router before the app finished opening.

Validation

  • pnpm run fmt:rs
  • cargo test -p bitfun-core infrastructure::debug_log::http_server::tests::starts_with_session_id_ingest_route -- --nocapture
  • cargo check -p bitfun-core
  • git diff --staged --check

@limityan limityan marked this pull request as ready for review May 30, 2026 01:28
@limityan limityan merged commit fd464b0 into GCWing:main May 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant