Fix/updating bindings#27
Open
ruslanti wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes a small maintenance update to the NGINX module wrapper header and updates the GitHub Actions Rust workflow to build against a newer NGINX source distribution during CI.
Changes:
- Update the copyright year in
nginx_module/wrapper.h. - Change the CI workflow’s NGINX download/build step to target NGINX
1.31.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
nginx_module/wrapper.h |
Updates header copyright year. |
.github/workflows/rust.yml |
Updates CI to download/build a different NGINX version (currently with an extraction issue). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| apt install -y curl build-essential libpcre3 libpcre3-dev zlib1g zlib1g-dev libssl-dev libgd-dev libxml2 libxml2-dev uuid-dev clang | ||
| curl http://nginx.org/download/nginx-1.25.3.tar.gz | tar xz | ||
| cd nginx-1.25.3 && ./configure --conf-path=/etc/nginx/nginx.conf --with-pcre --lock-path=/var/lock/nginx.lock --pid-path=/var/run/nginx.pid --with-http_ssl_module --modules-path=/etc/nginx/modules --with-http_v2_module --add-module=../examples/simple && make && make install | ||
| curl http://nginx.org/download/nginx-1.31.1.zip | tar xz |
climagabriel
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.