add support for cross-compiling for RVA23#3
Merged
korewaChino merged 5 commits intoFyraStack:mainfrom Apr 5, 2026
Merged
Conversation
Contributor
|
@remexre Code looks good to me. Just made a few naming tweaks and added x86 artifact upload, since we didn't have that and it is useful. x86 should probably be in another PR, but I just wanna deal with it now. The x86 upload didn't work and I am not sure why. Can you help me debug it (probably via signal)? Once that is working, I think it is ready to merge. Can you look over my changes and let me know if you have any issues? |
Contributor
|
I got x86 artifact upload working. Unless you have any issues with my changes, I think it is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.