Repository navigation
Strip newlines at the workspace log sink - #73
Merged
Merged
Conversation
Apply the canonical newline sanitizer inline at console.error so no user-influenced error text can forge log entries.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const csrf = randomBytes(32).toString("base64url"); const runs = new Map<string, WorkspaceRun>(); | ||
| const assets = resolve(dirname(fileURLToPath(import.meta.url)), "../workspace-assets"); | ||
| const server = createServer(async (req, res) => { securityHeaders(res); try { await route(req, res); } catch (error) { console.error("[MCP Rigor workspace] internal error:", messageOf(error)); json(res, 500, { error: { code: "MCP-WEB-500", message: "Internal server error" } }); } }); | ||
| const server = createServer(async (req, res) => { securityHeaders(res); try { await route(req, res); } catch (error) { console.error("[MCP Rigor workspace] internal error:", messageOf(error).replace(/\r?\n/g, " ")); json(res, 500, { error: { code: "MCP-WEB-500", message: "Internal server error" } }); } }); |
Collaborator
Author
|
Great job! No new security vulnerabilities introduced in this pull requestCommunicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log-injection fix: applies the newline sanitizer inline at the
console.errorsink in the workspace 500 handler.158/158 tests.