[BUGFIX] Hit Window Offset By FPS

[Lasercar]

Linked Issues

Fixes #5667

Description

See previous PR for details: #5734

Important

Requires FunkinCrew/funkin.assets#331

Screenshots/Videos

[Kade-github]

Eric apparently has thoughts that he never put on the original, so im assigning him here as well

[EliteMasterEric]

Why does this add data to the note style? And the value has two DIFFERENT default values?

I'm really cynical about PRs like this because the potential risks are so dire and the potential upsides seem like at best a placebo.

[Lasercar]

Why does this add data to the note style? And the value has two DIFFERENT default values?

I'm really cynical about PRs like this because the potential risks are so dire and the potential upsides seem like at best a placebo.

The pixel notestyle was still offset if the value for the default notestyle is used on it. Custom notestyles will probably have the same issue too, so the only solution is to create a value that can be modified until a perfect note hit matches the strumline at all fps caps, as much as I hate it.

For example, on downscroll, the pixel note style was looking like this:

While the default style looked like this:

Also, we still can't get an accurate current fps right now because of lime, so these changes are really all that can be done at the moment until that changes.

[JackXson-Real]

Also, we still can't get an accurate current fps right now because of lime, so these changes are really all that can be done at the moment until that changes

even if we could get accurate current FPS, it sounds like it would cause loads of lag since it would be constantly changing based on the FPS, and that can change a lot in a small amount of time. I’m not entirely sure how lime works though so maybe it wouldn’t cause any lag.