feat: Enhance App Running Experience with K8s Execution and Confirmation Dialog #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add execCommandInBackground method in sandbox-manager.ts for nohup execution - Add isPortListening and killProcessOnPort methods for app status detection - Create /api/sandbox/[id]/exec endpoint for background command execution - Create /api/sandbox/[id]/app-status endpoint for status check and stop - Add Deploy button in terminal-toolbar with polling-based status detection - Support start/stop toggle with visual feedback (Deploy -> Live -> Stop) Closes #116
…ckground persistence and ignore `plan.md`
…ization parameter to ttyd execution functions.
… execution and add related test scripts.
…y and add internal scripts for background command execution testing.
✅ PR Check Results: PassedBuild Checks
✨ Great work!All checks passed successfully. Your PR is ready for review. Details:
🔗 View Details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refines the application deployment workflow by reverting the background execution strategy to a stable K8s-based approach and significantly improving the user experience with a new confirmation dialog.
Key Changes
1. Robust Background Execution (Backend)
nohup/tmuxviattydapproach withk8sService.execCommandInBackground(usingkubectl exec). This ensures greater stability and alignment with the system architecture.Authorizationpropagation inttyd-executility to fix connection issues in specific environments.2. "Run App" Workflow Overhaul (Frontend)
Verification
Ref: d62366c...