Skip to content

ci: install test dependencies in real-model nightly - #186

Open
WilliamK112 wants to merge 1 commit into
FreshCode-Org:mainfrom
WilliamK112:fix/nightly-real-model-deps
Open

ci: install test dependencies in real-model nightly#186
WilliamK112 wants to merge 1 commit into
FreshCode-Org:mainfrom
WilliamK112:fix/nightly-real-model-deps

Conversation

@WilliamK112

Copy link
Copy Markdown
Contributor

Description

The nightly real-model workflow has failed during test collection for at least its last 20 runs. It installs the semantic/benchmark/CLI runtime extras, then asks pytest to collect the entire tests/ tree before applying -k. Test modules outside the selected subset import development dependencies such as jsonschema and sqlalchemy, so collection stops before any real-model tests run.

This change:

  • installs the existing dev extra alongside semantic, matching the repository's documented test environment
  • removes redundant direct pytest/pytest-cov and benchmark/CLI dependencies already provided by dev
  • adds a workflow contract test so the nightly lane cannot silently drop its test dependencies again

Failed run demonstrating the collection error: https://github.com/FreshCode-Org/freshdata/actions/runs/33608540511

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor / Style / Performance improvement

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Type checks (mypy) and linter checks (ruff) pass locally

Validation

  • Reproduced the current workflow failure: 10 collection errors from missing jsonschema/sqlalchemy
  • Built the full development artifact pipeline with Python 3.12 and the corrected install
  • pytest tests -k "semantic or models or cleanbench" -q --no-cov: passed (1 skipped)
  • pytest tests/test_phase5_backcompat.py --no-cov: 16 passed
  • Full fast lane: 4,045 passed, 11 skipped, 12 deselected; macOS coverage remained at the current 91.98% baseline, below the repository's Linux-oriented 93% gate
  • ruff check tests/test_phase5_backcompat.py: passed
  • mypy src/freshdata: passed
  • Workflow YAML parse and git diff --check: passed

AI-assisted implementation was reviewed and validated by the contributor.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 2f3eea6c-0300-49b2-9563-6b2eb4fb75f8


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T15:36:25.285017Z 8c07087 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant