ci: install test dependencies in real-model nightly - #186
Open
WilliamK112 wants to merge 1 commit into
Open
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The nightly real-model workflow has failed during test collection for at least its last 20 runs. It installs the semantic/benchmark/CLI runtime extras, then asks pytest to collect the entire
tests/tree before applying-k. Test modules outside the selected subset import development dependencies such asjsonschemaandsqlalchemy, so collection stops before any real-model tests run.This change:
devextra alongsidesemantic, matching the repository's documented test environmentpytest/pytest-covand benchmark/CLI dependencies already provided bydevFailed run demonstrating the collection error: https://github.com/FreshCode-Org/freshdata/actions/runs/33608540511
Type of Change
Checklist
mypy) and linter checks (ruff) pass locallyValidation
jsonschema/sqlalchemypytest tests -k "semantic or models or cleanbench" -q --no-cov: passed (1 skipped)pytest tests/test_phase5_backcompat.py --no-cov: 16 passedruff check tests/test_phase5_backcompat.py: passedmypy src/freshdata: passedgit diff --check: passedAI-assisted implementation was reviewed and validated by the contributor.