Fix compliance findings in Frends.JSON.ConvertJSONStringToJToken - #41
Open
MichalFrends1 with Copilot wants to merge 2 commits into
Open
Fix compliance findings in Frends.JSON.ConvertJSONStringToJToken#41MichalFrends1 with Copilot wants to merge 2 commits into
MichalFrends1 with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: MichalFrends1 <167774394+MichalFrends1@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compliance findings in Frends.JSON.ConvertJSONStringToJToken
Fix compliance findings in Frends.JSON.ConvertJSONStringToJToken
Aug 4, 2026
MichalFrends1
marked this pull request as ready for review
August 4, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves task analyzer findings (FT0004, FT0007, FT0011), upgrades target framework to net8.0, and adds standard error handling infrastructure.
Changes
ConvertJSONStringToJToken.csproj—net6.0→net8.0; version1.1.0→1.2.0UnitTests.csproj—net6.0→net8.0JSONclass — madestatic(FT0004)OptionsandCancellationTokenparameters (FT0007); wrapped body in try/catch usingErrorHandlerResult— switched toinit-only properties; addedErrorproperty (FT0011)Definitions/Options.cs—ThrowErrorOnFailure,ErrorMessageOnFailureDefinitions/Error.cs—Message,AdditionalInfoHelpers/ErrorHandler.cs— standardHandle(exception, options)extensionErrorHandlerTests.cs— covers throw-on-failure, return-on-failure, and custom error message pathsUpdated call signature: