Skip to content

Add configurable certificate StoreLocation for certificate authentication #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalFrends1 merged 23 commits into from
Mar 3, 2026
Merged

Add configurable certificate StoreLocation for certificate authentication #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
901cd12
Initial plan
Copilot Nov 14, 2025
809a61b
Add CertificateStoreLocation selection for Frends.HTTP.Request module
Copilot Nov 14, 2025
5b39909
Add CertificateStoreLocation selection to all HTTP modules
Copilot Nov 14, 2025
244982c
Bump versions and add changelog entries for CertificateStoreLocation …
Copilot Nov 18, 2025
bd9c367
Fix DownloadFile tests by replacing external URL dependency with Mock…
Copilot Nov 26, 2025
9eaf7b0
Fix MockHttp to create fresh response content for each request
Copilot Nov 26, 2025
2accf6c
Add unit tests for CertificateStoreLocation and error cases to increa…
Copilot Nov 26, 2025
ad1d4fd
Fix TestFileDownload_WithCertificateStoreLocation_LocalMachine_NotFou…
Copilot Nov 26, 2025
1aa4c77
Fix whitespace formatting issues in UnitTests.cs and Extensions.cs
Copilot Dec 2, 2025
c5cd0d7
Add additional unit tests to increase DownloadFile code coverage to 80%+
Copilot Dec 2, 2025
5335864
Clean up unit tests, remove http mock
jefim Dec 4, 2025
4e11d2f
Refactor unit tests for file download with certificate handling and i…
jefim Jan 5, 2026
a4cb754
Merge branch 'main' into copilot/add-storelocation-selection-certific…
MatteoDelOmbra Mar 2, 2026
d5919f0
cr changes
MatteoDelOmbra Mar 2, 2026
07e1b6d
Merge remote-tracking branch 'origin/copilot/add-storelocation-select…
MatteoDelOmbra Mar 2, 2026
44f24ec
crchanges
MatteoDelOmbra Mar 2, 2026
8ab8a2d
cr changes
MatteoDelOmbra Mar 2, 2026
33d7882
cr changes
MatteoDelOmbra Mar 2, 2026
82ee231
linter fixes
MatteoDelOmbra Mar 2, 2026
24fb38d
add tests
MatteoDelOmbra Mar 2, 2026
914fc84
switch tests to windows
MatteoDelOmbra Mar 2, 2026
8e766a8
switch all tests to windows
MatteoDelOmbra Mar 2, 2026
d3910cc
fix date
MatteoDelOmbra Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/RequestBytes_build_and_test_on_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

jobs:
build:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_main.yml@main
uses: FrendsPlatform/FrendsTasks/.github/workflows/build_main.yml@main
with:
workdir: Frends.HTTP.RequestBytes
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/RequestBytes_build_and_test_on_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@

jobs:
build:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_test.yml@main
uses: FrendsPlatform/FrendsTasks/.github/workflows/build_test.yml@main
with:
workdir: Frends.HTTP.RequestBytes
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}
test_feed_api_key: ${{ secrets.TASKS_TEST_FEED_API_KEY }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
4 changes: 2 additions & 2 deletions .github/workflows/Request_build_and_test_on_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@

on:
push:
branches:
branches:
- main
paths:
- 'Frends.HTTP.Request/**'
workflow_dispatch:

jobs:
build:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_main.yml@main
uses: FrendsPlatform/FrendsTasks/.github/workflows/build_main.yml@main
with:
workdir: Frends.HTTP.Request
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/Request_build_and_test_on_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@

jobs:
build:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_test.yml@main
uses: FrendsPlatform/FrendsTasks/.github/workflows/build_test.yml@main
with:
workdir: Frends.HTTP.Request
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}
test_feed_api_key: ${{ secrets.TASKS_TEST_FEED_API_KEY }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/SendAndReceiveBytes_build_and_test_on_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

jobs:
build:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_main.yml@main
uses: FrendsPlatform/FrendsTasks/.github/workflows/build_main.yml@main
with:
workdir: Frends.HTTP.SendAndReceiveBytes
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/SendAndReceiveBytes_build_and_test_on_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@

jobs:
build:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_test.yml@main
uses: FrendsPlatform/FrendsTasks/.github/workflows/build_test.yml@main
with:
workdir: Frends.HTTP.SendAndReceiveBytes
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}
test_feed_api_key: ${{ secrets.TASKS_TEST_FEED_API_KEY }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/SendBytes_build_and_test_on_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

jobs:
build:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_main.yml@main
uses: FrendsPlatform/FrendsTasks/.github/workflows/build_main.yml@main
with:
workdir: Frends.HTTP.SendBytes
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/SendBytes_build_and_test_on_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@

jobs:
build:
uses: FrendsPlatform/FrendsTasks/.github/workflows/linux_build_test.yml@main
uses: FrendsPlatform/FrendsTasks/.github/workflows/build_test.yml@main
with:
workdir: Frends.HTTP.SendBytes
secrets:
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}
test_feed_api_key: ${{ secrets.TASKS_TEST_FEED_API_KEY }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
4 changes: 4 additions & 0 deletions Frends.HTTP.DownloadFile/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [1.4.0] - 2026-03-02
### Added
- Added CertificateStoreLocation option to allow selection between CurrentUser and LocalMachine certificate stores when using certificate authentication.

## [1.3.0] - 2025-05-15
### Changed
- Added new Overwrite parameter to control whether the downloaded file should replace an existing one.
Expand Down
1 change: 1 addition & 0 deletions ...ds.HTTP.DownloadFile/Frends.HTTP.DownloadFile.Tests/Frends.HTTP.DownloadFile.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Pluralsight.Crypto" Version="1.1.0" />
<PackageReference Include="RichardSzalay.MockHttp" Version="7.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading
Loading