Skip to content

fix regex issue - #88

Open
MichalFrends1 wants to merge 2 commits into
mainfrom
FSPES-150
Open

fix regex issue#88
MichalFrends1 wants to merge 2 commits into
mainfrom
FSPES-150

Conversation

@MichalFrends1

@MichalFrends1 MichalFrends1 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Please review my changes :)

Review Checklist

  • Task version updated (x.x.0)
  • CHANGELOG.md updated
  • Solution builds
  • Warnings resolved (if possible)
  • Typos resolved
  • Tests cover new code
  • Description how to run tests locally added to README.md (if needed)
  • All tests pass locally

Summary by CodeRabbit

  • New Features

    • File masks now treat brackets and other regex-special characters as literal by default.
    • Regular-expression matching remains available by prefixing masks with <regex>.
    • Added examples clarifying literal, wildcard, and regular-expression mask usage.
  • Bug Fixes

    • Backups now correctly handle filenames containing round or square brackets.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@MichalFrends1, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0de2be19-017a-4f08-902b-51ed21a0b2d5

📥 Commits

Reviewing files that changed from the base of the PR and between ad1e1c9 and ee34872.

📒 Files selected for processing (2)
  • Frends.Files.LocalBackup/CHANGELOG.md
  • Frends.Files.LocalBackup/Frends.Files.LocalBackup/LocalBackup.cs

Walkthrough

LocalBackup now treats file-mask regex characters as literals by default. The <regex> prefix enables regular-expression matching. Tests cover regex opt-in and exact filenames containing round or square brackets. The package version is 3.0.0.

Changes

LocalBackup mask matching

Layer / File(s) Summary
Literal masks and explicit regex mode
Frends.Files.LocalBackup/Frends.Files.LocalBackup/LocalBackup.cs, Frends.Files.LocalBackup/Frends.Files.LocalBackup/Definitions/Input.cs, Frends.Files.LocalBackup/Frends.Files.LocalBackup.Tests/UnitTests.cs, Frends.Files.LocalBackup/CHANGELOG.md, Frends.Files.LocalBackup/Frends.Files.LocalBackup/Frends.Files.LocalBackup.csproj
Wildcard masks now escape regex-special characters. Regex masks require the <regex> prefix. Documentation and release notes describe both modes. Tests cover regex masks and filenames containing brackets. The package version is 3.0.0.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checked the backup trail,
Where brackets once could make it fail.
“Literal masks now keep their shape,
Regex waits behind its <regex> gate.”
Fresh tests hop by, files safe and bright.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title relates to the regex change but does not identify the specific backup mask behavior or bracket-handling fix. Use a specific title such as "Treat file-mask regex characters as literals by default".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch FSPES-150

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Frends.Files.LocalBackup/CHANGELOG.md`:
- Around line 3-18: Update the 3.0.0 entry in the changelog by adding a ###
Changed section after ### Fixed and moving the default literal-mask semantics,
BREAKING CHANGE upgrade note, and all related <regex> migration examples into
it, leaving only the bracket-handling bug fix under ### Fixed.

In `@Frends.Files.LocalBackup/Frends.Files.LocalBackup/LocalBackup.cs`:
- Around line 162-164: Update the wildcard regex construction in the pattern
assignment to replace escaped `?` with `.` rather than `.+`, preserving the
documented one-character wildcard behavior while leaving `*` handling unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b7c0918-999b-4a3f-8032-24742332db59

📥 Commits

Reviewing files that changed from the base of the PR and between fb90a2f and ad1e1c9.

📒 Files selected for processing (5)
  • Frends.Files.LocalBackup/CHANGELOG.md
  • Frends.Files.LocalBackup/Frends.Files.LocalBackup.Tests/UnitTests.cs
  • Frends.Files.LocalBackup/Frends.Files.LocalBackup/Definitions/Input.cs
  • Frends.Files.LocalBackup/Frends.Files.LocalBackup/Frends.Files.LocalBackup.csproj
  • Frends.Files.LocalBackup/Frends.Files.LocalBackup/LocalBackup.cs

Comment thread Frends.Files.LocalBackup/CHANGELOG.md
Comment thread Frends.Files.LocalBackup/Frends.Files.LocalBackup/LocalBackup.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant