Add MQTT_Publish API with ACK handling #337
Conversation
AniruddhaKanhere
force-pushed
the
AddPublish
branch
2 times, most recently
from
e942ad7 to
49fbfc7
Compare
| LogDebug( ( "Packet identifier %hu.", | ||
| ( unsigned short ) *pPacketIdentifier ) ); | ||
|
|
||
| /* Packet identifier cannot be 0. */ |
There was a problem hiding this comment.
Should check this right after L727?
There was a problem hiding this comment.
I agree that L727 would be the better place. However, that breaks the pattern that we increment the index after we get a value out from the buffer. This will not cause any issues since as long as the return value of the function is not MQTTSuccess, any and all values returned by the function in the parameters are invalid and should not be consumed.
source/core_mqtt_serializer.c
Outdated
| pLocalIndex = &pLocalIndex[ variableLengthEncodedSize( propertyLength ) ]; | ||
|
|
||
| /*Validate the remaining length.*/ | ||
| if( remainingLength != ( propertyLength + variableLengthEncodedSize( propertyLength ) + 3U ) ) |
There was a problem hiding this comment.
I don't understand this check. What does remainingLength represent here? And why would it equal the length of the properties (encoded + decoded)? Why isn't this equal to variableLengthEncodedSize( propertyLength ) + 3U?
There was a problem hiding this comment.
It is an artifact of how the code was written earlier.
I reworked it. Let me know if that makes sense.
AniruddhaKanhere
force-pushed
the
AddPublish
branch
from
49fbfc7 to
2182737
Compare
AniruddhaKanhere
force-pushed
the
AddPublish
branch
from
2182737 to
e9942c7
Compare
3 participants
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.