Fix incorrect state transition #1302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a TCP connection in eCONNECT_SYN state times out after exceeding the maximum retry count, the socket was incorrectly transitioning to eCLOSE_WAIT state instead of eCLOSED. According to the standard TCP state machine (RFC 793): - eCONNECT_SYN is the state where a client has sent a SYN and is waiting for a SYN-ACK - When connection establishment fails (timeout or RST), the socket should transition to eCLOSED state This fix: 1. Changes the state transition in prvTCPSendPacket() from eCLOSE_WAIT to eCLOSED when SYN retries are exhausted 2. Updates vTCPStateChange() to handle the eCONNECT_SYN -> eCLOSED transition, ensuring connection state change callbacks are properly triggered. This also aligns the timeout behavior with the existing RST handling code, which correctly uses eCLOSED state (see FreeRTOS_TCP_IP.c:859). Files changed: - source/FreeRTOS_TCP_Transmission.c: Fix state transition - source/FreeRTOS_TCP_IP.c: Update vTCPStateChange to handle eCLOSED transition from connecting states
Contributor
|
@Fr3ya , I have fixed the unit tests. I will send you an update later today. |
Contributor
|
@Fr3ya , I made some changes to repair the unit testing and 100% coverage : Can you apply my patch and do a new commit? Here are the plain files in a zip: ut_changes_htibosch.zip |
Author
|
Hi @htibosch, I have applied the patch that you posted, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a TCP connection in eCONNECT_SYN state times out after exceeding the maximum retry count, the socket was incorrectly transitioning to eCLOSE_WAIT state instead of eCLOSED.
According to the standard TCP state machine (RFC 793):
This fix:
eCLOSE_WAITtoeCLOSEDwhen SYN retries are exhaustedeCONNECT_SYN -> eCLOSEDtransition, ensuring connection state change callbacks are properly triggered.This also aligns the timeout behavior with the existing RST handling code, which correctly uses
eCLOSEDstate (see FreeRTOS_TCP_IP.c:859).Files changed:
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.