add tests for replicating with hypercore and with multifeed#1
Open
ameba23 wants to merge 2 commits intoFrando:masterfrom
Open
add tests for replicating with hypercore and with multifeed#1ameba23 wants to merge 2 commits intoFrando:masterfrom
ameba23 wants to merge 2 commits intoFrando:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i dont actually want to merge this, at least for now, but here are some additional tests, one of which fails, to demonstrate a difficulty with using this.
to replicate after authenticating we can pass the
hypercore-protocolstream into the replication method withopts.stream = protocolStream. This works great with an individual hypercore, butmultifeed'sreplicatemethod doesnt take a stream as an option.I am considering making a PR to multifeed to allow this, and maybe i would use these tests to help explain why it would be useful. But maybe there is actually an easier way to go about this. @Frando