Fix global PyTorch initializer leak in build_vae_var - #185
Open
primorLee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset_parametersoverrides to VAR/VQVAE constructionfinallyblock on both success and failureProblem
build_vae_var()disables built-in initialization by replacingreset_parameterson eight globaltorch.nnclasses. Those class methods were never restored. After one VAR build, unrelated modules created anywhere in the same Python process could therefore keep uninitialized weights.A minimal CPU reproduction on current
mainprintslinear_reset_restored=Falseafterbuild_vae_var()returns.Fix
Save the original class methods, keep the existing no-initialization fast path while VQVAE and VAR are constructed, and restore the methods in
finally. The existing explicitvar_wo_ddp.init_weights(...)remains unchanged.Validation
python -m pytest tests/test_model_initialization.py -q(2 passed, 16 subtests)python -m compileall -q models/__init__.py tests/test_model_initialization.pyFixes #159