fix(storage): resolve MediaStore URIs before scoped requests#339
Open
sjug wants to merge 2 commits intoFossifyOrg:mainfrom
Open
fix(storage): resolve MediaStore URIs before scoped requests#339sjug wants to merge 2 commits intoFossifyOrg:mainfrom
sjug wants to merge 2 commits intoFossifyOrg:mainfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
MediaScannerConnection.scanFile(...)and verifies resolved MediaStore IDs before passing URIs to Android R+ write/delete/trash requests.content://media/external/images/media/0.callback(false).FileDirItem.assembleContentUri()nullable instead of fabricating invalid IDs.This is a breaking API/behavior change and is intended for the next major commons release, e.g.
7.0.0.Required by the Gallery scoped-storage overwrite-save fix for FossifyOrg/Gallery#1031.
Tests performed
./gradlew :commons:compileDebugKotlin./gradlew :commons:publishToMavenLocal/media/0URI crash.Before & after preview
N/A — no UI changes.
Closes the following issue(s)
N/A — prerequisite library fix for FossifyOrg/Gallery#1031.
Checklist
CHANGELOG.md(if applicable; noCHANGELOG.mdexists in this repo).