fix(editor): replace unaligned native photo filters library#1037
Open
sjug wants to merge 2 commits intoFossifyOrg:mainfrom
Open
fix(editor): replace unaligned native photo filters library#1037sjug wants to merge 2 commits intoFossifyOrg:mainfrom
sjug wants to merge 2 commits intoFossifyOrg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
androidphotofiltersdependency, which ships a prebuiltarm64-v8a/libNativeImageProcessor.sowith 4 KB ELF segment alignment.System.loadLibrary("NativeImageProcessor")call from the editor.Aligned16KBlint baseline entries for the deleted native library.Android 15+ / target SDK 35+ apps need native libraries to support 16 KB page-size devices. Since the upstream AndroidPhotoFilters native library is unmaintained and fails that check, this removes the native dependency from Gallery's APK entirely.
Tests performed
./gradlew :app:assembleFossDebuglibNativeImageProcessor.so.arm64-v8aandx86_64native libraries have0x4000ELFLOADalignment withreadelf -lW.zipalign -c -P 16 -v 4.Before & after preview
N/A — no UI changes.
Closes the following issue(s)
N/A — Android 16 KB page-size compatibility fix.
Checklist
CHANGELOG.md(if applicable).