Repository navigation
fix: keep files whose names are only dots when unhiding - #522
Closed
ibrahim-iqbal wants to merge 1 commit into
Closed
ibrahim-iqbal wants to merge 1 commit into
ibrahim-iqbal wants to merge 1 commit into
Conversation
Unhiding "..." produced the name "..", which names the parent folder, so the rename failed and the file and its content were lost. Leave such names as they are, the same way a name that is already visible is skipped.
Contributor
|
Fossify accepts code contributions only for open issues labeled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #517.
Unhiding a file named
...computed the new name.., which is the parent folder. The rename then failed and the file and its content were gone.toggleItemVisibilitynow leaves the file alone when the unhidden name would be empty,.or.., the same way it already skips a name that is already visible. Other names, including...., are unhidden as before.Checked:
:app:detektand:app:compileFossDebugKotlinpass. I did not run it on a device.