Skip to content

fix(types): expose supported options and the revocation response #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(types): expose supported options and the revocation response #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/appauth-public-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-native-app-auth": patch
---

Add registration timeout, logout custom-browser options and revocation clientSecret to the declarations. Correct revoke() from Promise<void> to the fetch Response it already returns at runtime.
7 changes: 5 additions & 2 deletions packages/react-native-app-auth/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export type RegistrationConfiguration = BaseConfiguration & {
dangerouslyAllowInsecureHttpRequests?: boolean;
customHeaders?: CustomHeaders;
additionalHeaders?: AdditionalHeaders;
connectionTimeoutSeconds?: number;
};

export interface RegistrationResponse {
Expand Down Expand Up @@ -97,6 +98,8 @@ export type EndSessionConfiguration = BaseAuthConfiguration & {
additionalParameters?: { [name: string]: string };
dangerouslyAllowInsecureHttpRequests?: boolean;
iosPrefersEphemeralSession?: boolean;
iosCustomBrowser?: AuthConfiguration['iosCustomBrowser'];
androidAllowCustomBrowsers?: AuthConfiguration['androidAllowCustomBrowsers'];
};

export interface AuthorizeResult {
Expand Down Expand Up @@ -154,9 +157,9 @@ export function refresh(
): Promise<RefreshResult>;

export function revoke(
config: BaseAuthConfiguration,
config: BaseAuthConfiguration & { clientSecret?: string },
revokeConfig: RevokeConfiguration
): Promise<void>;
): Promise<Response>;

export function logout(
config: EndSessionConfiguration,
Expand Down