fix(android): preserve structured additional response parameters - #1132
Open
OskarEichler wants to merge 1 commit into
Open
fix(android): preserve structured additional response parameters#1132OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
|
@OskarEichler is attempting to deploy a commit to the Nearform Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Decode JSON objects and arrays once, preserve nested null values, accept null native values without a crash, and retain scalar/malformed strings. Iterate map entries directly and share the base authorization response serializer when adding a PKCE verifier.
Breaking / observable changes
Observable response correction: JSON-array additional parameters become arrays, and nested JSON null stays null instead of the string "null". Scalar strings (including "null", numbers and booleans), permissive legacy objects, field names and PKCE response shapes are preserved. Consumers that relied on the old array/string or null/string mismatch should adapt.
Verification
Compiled actual Java serializers pass structured array/object/null, malformed/scalar string, permissive parser and PKCE field-equivalence checks. No claimed timing benchmark; the implementation avoids the prior repeated lookup and exception-on-ordinary-scalar parsing path.
Each patch was applied independently to upstream commit
6f9090ce1b991c0acc2a6f5dc8bea838deaf4f7aand passed its targeted external actual-source diagnostics or standalone type/lockfile check. The combined fixes pass 75 focused diagnostics. These use synthetic values, controlled native/bridge doubles and disposable filesystem projects, not real credentials.Combined branch checks:
No checked-in test/spec files were added, changed or disabled. The source changes are supported by external reproducible diagnostics because this audit's repository policy prohibits checked-in test edits. Live OAuth providers, physical-device/browser authentication and a full Expo native build were not exercised. React Doctor reports two warnings: the discovery response is explicitly guarded by response.ok === false, and the demo pending reset is inside finally; both paths are exercised by focused checks. No rules were suppressed.
Scope
packages/react-native-app-auth/android/src/main/java/com/rnappauth/utils/MapUtil.javapackages/react-native-app-auth/android/src/main/java/com/rnappauth/utils/TokenResponseFactory.java.changeset/appauth-android-response-values.mdUnrelated audit fixes are submitted separately. The separate iOS process-global OIDURLSessionProvider request-isolation issue is not claimed fixed by these changes.