Skip to content

fix(rpc agent): remove useless verrification to handle properly main node agent start#311

Merged
arnaud-moncel merged 2 commits into
mainfrom
fix/rpc/auth
May 22, 2026
Merged

fix(rpc agent): remove useless verrification to handle properly main node agent start#311
arnaud-moncel merged 2 commits into
mainfrom
fix/rpc/auth

Conversation

@arnaud-moncel
Copy link
Copy Markdown
Member

@arnaud-moncel arnaud-moncel commented May 22, 2026

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Note

Remove anti-replay signature tracking from RPC agent authentication middleware

Removes the signature reuse detection system from Authentication to align with the Node TS rpc-agent behavior. The SIGNATURE_REUSE_WINDOW constant, @@used_signatures cache, @@signatures_mutex, and cleanup_old_signatures method are all deleted. Validity is now determined solely by HMAC equality and timestamp freshness.

  • Behavioral Change: repeated requests with the same timestamp and signature within the allowed time window are now accepted instead of rejected.

Changes since #311 opened

  • Removed test coverage for signature cleanup and thread safety in authentication middleware [ae79ea2]
  • Renamed test example description for concurrent request handling [ae79ea2]

Macroscope summarized f9620ea.

@matthv
Copy link
Copy Markdown
Member

matthv commented May 22, 2026

I think you can remove also the following tests (in authentication_spec.rb)

- removes signatures older than ALLOWED_TIME_DIFF
- mutex protects shared state from race conditions

@arnaud-moncel arnaud-moncel merged commit 684a966 into main May 22, 2026
44 checks passed
@arnaud-moncel arnaud-moncel deleted the fix/rpc/auth branch May 22, 2026 13:59
forest-bot added a commit that referenced this pull request May 22, 2026
## [1.30.5](v1.30.4...v1.30.5) (2026-05-22)

### Bug Fixes

* **rpc agent:** remove useless verrification to handle properly main node agent start ([#311](#311)) ([684a966](684a966))
@forest-bot
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.30.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants