fix(rpc): action with file

[arnaud-moncel]

Definition of Done

General

• Write an explicit title for the Pull Request, following Conventional Commits specification
• Test manually the implemented changes
• Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

• Consider the security impact of the changes made

Note

Add file action result support to RPC datasource action execution

• The RPC agent's ActionExecute route now detects File-type action results and builds a file-oriented HTTP response with encoded Content-Disposition, X-Forest-Action-Type, and optional X-Forest-Action-Response-Headers headers.
• RpcClient#call_rpc gains a with_response flag that returns the raw Faraday::Response instead of just the body, enabling the RPC datasource collection to reconstruct file results from response headers.
• The RPC schema emitted by the agent now includes an actions map per collection, exposing only scope, is_generate_file, static_form, description, and submit_button_label — form definitions and execute callbacks are omitted.
• BaseAction now accepts static_form as a constructor argument and from_plain_object passes it through, so the attribute is correctly reflected when building actions from schema.

^{Macroscope summarized 37ae6bd.}

[qltysh]

1 new issue

Tool	Category	Rule	Count
qlty	Structure	Function with many parameters (count = 7): call_rpc	1

[qltysh]

Function with many parameters (count = 7): call_rpc [qlty:function-parameters]

[macroscopeapp]

🟢 Low forest_admin_datasource_rpc/collection.rb:198

When response_headers_header is an empty string or invalid JSON, JSON.parse raises JSON::ParserError and crashes action execution. The condition if response_headers_header is truthy for empty strings, so an absent or malformed header causes a hard failure rather than graceful fallback.

-      result[:response_headers] = JSON.parse(response_headers_header) if response_headers_header

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb around line 198:

When `response_headers_header` is an empty string or invalid JSON, `JSON.parse` raises `JSON::ParserError` and crashes action execution. The condition `if response_headers_header` is truthy for empty strings, so an absent or malformed header causes a hard failure rather than graceful fallback.

Evidence trail:
packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb lines 188-201 at REVIEWED_COMMIT: `response_headers_header` set from `response.headers['x-forest-action-response-headers']` (line 189), guard on line 198 `if response_headers_header` is truthy for empty strings in Ruby, `JSON.parse("")` raises `JSON::ParserError`. Ruby semantics: only `nil` and `false` are falsy; empty string is truthy.