fix(datasource-mongo): fix flaky create integration test#1550
Merged
Conversation
- Await connection.dropDatabase() instead of fire-and-forget - Add explicit Movie.createCollection() before saving data The test was flaky because introspection could run before the collection existed, resulting in "Collection 'movies' not found". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nbouliol
approved these changes
Apr 14, 2026
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
forest-bot
added a commit
that referenced
this pull request
Apr 14, 2026
## @forestadmin/datasource-mongo [1.6.9](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongo@1.6.8...@forestadmin/datasource-mongo@1.6.9) (2026-04-14) ### Bug Fixes * **datasource-mongo:** fix flaky create integration test ([#1550](#1550)) ([ef90e90](ef90e90))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
connection.dropDatabase()(was fire-and-forget, causing race condition)await Movie.createCollection()before saving dataThe test was flaky because MongoDB introspection could run before the collection existed, resulting in
"Collection 'movies' not found"with an empty collection list.Matches the pattern already used in
index.integration.test.ts.Test plan
index.integration.test.ts🤖 Generated with Claude Code
Note
Fix flaky
beforeEachsetup in MongoDB create integration testsAwaits the
dropDatabasecall and adds an awaitedcreateCollectioncall before seeding theInceptiondocument in thebeforeEachhooks of create.integration.test.ts and index.ssh.integration.test.ts. This ensures the database is fully dropped and theMoviescollection exists before each test runs, eliminating a race condition that caused intermittent failures.Macroscope summarized 13a37b7.