-
Notifications
You must be signed in to change notification settings - Fork 10
feat(workflow-executor): add guidance step type (PRD-272) #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Scra3
merged 1 commit into
feat/prd-214-setup-workflow-executor-package
from
feature/prd-272-guidance-step
Apr 7, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
packages/workflow-executor/src/executors/guidance-step-executor.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import type { StepExecutionResult } from '../types/execution'; | ||
| import type { GuidanceStepDefinition } from '../types/step-definition'; | ||
| import type { BaseStepStatus } from '../types/step-outcome'; | ||
|
|
||
| import { StepStateError } from '../errors'; | ||
| import patchBodySchemas from '../pending-data-validators'; | ||
| import BaseStepExecutor from './base-step-executor'; | ||
|
|
||
| export default class GuidanceStepExecutor extends BaseStepExecutor<GuidanceStepDefinition> { | ||
| protected async doExecute(): Promise<StepExecutionResult> { | ||
| const { incomingPendingData } = this.context; | ||
|
|
||
| if (!incomingPendingData) { | ||
| throw new StepStateError('Guidance step triggered without pending data'); | ||
| } | ||
|
|
||
| const parsed = patchBodySchemas.guidance.safeParse(incomingPendingData); | ||
|
|
||
| if (!parsed.success) { | ||
| throw new StepStateError( | ||
| `Invalid guidance input: ${parsed.error.issues.map(i => i.message).join(', ')}`, | ||
| ); | ||
| } | ||
|
|
||
| const { userInput } = parsed.data as { userInput: string }; | ||
|
|
||
| await this.context.runStore.saveStepExecution(this.context.runId, { | ||
| type: 'guidance', | ||
| stepIndex: this.context.stepIndex, | ||
| executionResult: { userInput }, | ||
| }); | ||
|
|
||
| return this.buildOutcomeResult({ status: 'success' }); | ||
| } | ||
|
|
||
| protected buildOutcomeResult(outcome: { | ||
| status: BaseStepStatus; | ||
| error?: string; | ||
| }): StepExecutionResult { | ||
| return { | ||
| stepOutcome: { | ||
| type: 'guidance', | ||
| stepId: this.context.stepId, | ||
| stepIndex: this.context.stepIndex, | ||
| ...outcome, | ||
| }, | ||
| }; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
executors/base-step-executor.ts:127patchAndReloadPendingDatauses a non-null assertion (!) onpatchBodySchemas[execution.type], butpatchBodySchemasis aPartialthat only includes schemas for specific step types. When the method is called with an execution whose type is not in that set (e.g.,conditionorread-record),schemabecomesundefinedandschema.safeParse(pendingData)throws a runtime error. Consider validating that the schema exists and throwing aStepStateErrorwhen the step type does not support pending data patches.🚀 Reply "fix it for me" or copy this AI Prompt for your agent: