Window frame PR #68

[CrystalSplitter]

This PR intends to allow support for using the native window frame on any platform. This has been primarily tested on Linux.

With this PR, one can force the native window frame with --force-frame. Additionally, you can now set it in the main app settings. This requires a restart to take effect.

[FrostBird347]

Other than that, I haven't noticed any issues on linux.

[CrystalSplitter]

That's great to hear! I would like to only merge this once:

1. We have an actual setting for this, beyond a flag. Though I would still like a flag for debugging.
2. We have gotten significant testing, as rendering errors are a concern here.

So it may be a bit until this is merged. But I wanted to get it out that this is what a solution would look like. Hopefully it does not feel too janky!

[CrystalSplitter]

--force-frame should now work anywhere, ideally. Separating on -- should not be needed.

[FrostBird347]

Brief testing hasn't revealed any issues, the only thing of note is that now you can't put -- before the --force-frame argument but I don't think that's necessarily a bad thing.

[CrystalSplitter]

That's correct, it's now treated as the same precedence of the electron flags themselves. We have to be sure we don't re-use a valid electron flag because of this.

[CrystalSplitter]

Bug found: both the top native window bar and the non-native menu bar are draggable with --force-frame.

[FrostBird347]

Strange, only the native bar appears to be draggable on my machine.

Though I am not fully sure what non-native menu bar you are talking about, I assume you are talking about the bar at the top that contains the settings/notification/reload buttons?

[CrystalSplitter]

This now has a setting! And I fixed some bugs I found. Please do test more!

[CrystalSplitter]

I'm going to review the CSS a bit to make sure I haven't missed something. But the setting part is done. Also perhaps interesting to @nubesurrealista, who wanted to do a similar feature for #85.

[FrostBird347]

When enabling the setting without the --force-frame argument, the non-native menu bar appears below the native bar:

It should look like this:

[CrystalSplitter]

Thanks for pointing it out! I believe I have a fix now.

[FrostBird347]

I can confirm that the issue has been fixed!

[CrystalSplitter]

I've extensively tested this now on Linux, and have gotten some (broken) testing on Windows done, and I think I've probably fixed issues there too?

Ultimately I like this feature, and without additional testers on other platforms, I'm limited to what I can actually verify. But Linux and Windows seem good, so merging.