Snap slider over empty months in direction of travel#63
Open
jakejellinek wants to merge 1 commit intomainfrom
Open
Snap slider over empty months in direction of travel#63jakejellinek wants to merge 1 commit intomainfrom
jakejellinek wants to merge 1 commit intomainfrom
Conversation
When the user drags the date slider to a month with no data, it now snaps to the nearest populated month in the direction they were dragging — right if moving forward, left if moving backward — instead of stopping on an empty slot and clearing the map. Uses populated_dates from the backend TimeRange response to know upfront which dates have data, so the snap is instant with no flicker.
jakejellinek
force-pushed
the
feat/slider-skip-empty-dates
branch
from
94bc9af to
0219d94
Compare
Contributor
Author
|
Not sure if we want this / if it is a user experience improvement. We could test in Dev and see if we like it? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
populated_datesfrom the backendTimeRangeresponse to know upfront which months are emptyall_datesifpopulated_datesis absent, preserving current behaviour)Test plan