Add Input Validation to Password Reset

[christopherholland-workday]

Previously, the new password used in password resets was not being validated to meet strength requirements. This change:

1. Adds validation to the new password
2. Small refactor to reduce code duplication related to the error message displayed when the new password has insufficient strength

[gemini-code-assist]

Summary of Changes

Hello @christopherholland-workday, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces essential input validation for new passwords during the password reset process, ensuring that all new passwords adhere to predefined strength requirements. It also includes a refactoring effort to consolidate the password validation logic into a single, reusable utility function, thereby improving code consistency and reducing duplication across the codebase.

Highlights

• Password Validation Enforcement: New password validation is now enforced during password reset operations to ensure strength requirements are met, preventing weak passwords from being set.
• Centralized Validation Logic: The logic for validating password strength has been extracted into a new utility function, validatePasswordOrThrow, promoting code reusability and maintainability across the application.
• Code Duplication Reduction: Existing inline password validation checks in user.ts and account.service.ts have been replaced with calls to the new centralized utility, significantly reducing redundant code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully addresses the lack of password validation in password reset flows and improves code maintainability by centralizing validation logic into a new validatePasswordOrThrow function. This refactoring reduces code duplication and ensures consistent password strength enforcement across the application. Overall, the changes are positive, but there are a couple of areas for improvement regarding type safety and comprehensive error reporting.

[gemini-code-assist]

The use of @ts-ignore here indicates a type safety issue. It's preferable to explicitly define the password property within the AccountDTO or a more specific DTO for password reset operations, rather than suppressing the TypeScript error. This improves code clarity and prevents potential runtime issues.

Suggested change

	// @ts-ignore
	interface PasswordResetUser extends Partial<User> {
	password?: string;
	}
	type AccountDTO = {
	user: PasswordResetUser;
	organization: Partial<Organization>;
	organizationUser: Partial<OrganizationUser>;
	workspace: Partial<Workspace>;
	workspaceUser: Partial<WorkspaceUser>;
	role: Partial<Role>;
	}
	// ... later in the code
	const password = data.user.password;

[christopherholland-workday]

Same as before, not sure if a major concern?