-
-
Notifications
You must be signed in to change notification settings - Fork 23.6k
fixed incorrect ollama embedding api endpoint #5658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fixed incorrect ollama embedding api endpoint #5658
Conversation
Summary of ChangesHello @smartcoder0777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the Ollama embedding functionality was failing due to an incorrect API endpoint. The changes involve updating the endpoint path to the correct one and migrating the underlying Langchain library usage for Ollama embeddings. This migration also necessitated adjusting a parameter name to ensure full compatibility and proper operation with the new library, ultimately restoring the intended functionality of Ollama embeddings. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates the Ollama embedding node to use the newer @langchain/ollama package, which resolves an issue with an incorrect API endpoint. The changes correctly adapt the code to the new library's API, and the component version has been appropriately incremented to reflect this breaking change. I've added one suggestion to improve code conciseness. Also, please note there's a small typo in the PR title and description ('incorrected' should be 'incorrect').
packages/components/nodes/embeddings/OllamaEmbedding/OllamaEmbedding.ts
Outdated
Show resolved
Hide resolved
used changed nullish coalescing operator Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
fixed: #5637
fixed incorrected ollama embedding api endpoint api/embedding to api/embed
Here is the screenshot of ollama logs after fixing issue:

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=191128130