Skip to content

Conversation

@smartcoder0777
Copy link

fixed: #5637

fixed incorrected ollama embedding api endpoint api/embedding to api/embed

Here is the screenshot of ollama logs after fixing issue:
image

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=191128130

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @smartcoder0777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the Ollama embedding functionality was failing due to an incorrect API endpoint. The changes involve updating the endpoint path to the correct one and migrating the underlying Langchain library usage for Ollama embeddings. This migration also necessitated adjusting a parameter name to ensure full compatibility and proper operation with the new library, ultimately restoring the intended functionality of Ollama embeddings.

Highlights

  • API Endpoint Correction: The Ollama embedding API endpoint has been corrected from api/embedding to api/embed to resolve an issue with incorrect API calls.
  • Langchain Library Migration: The Langchain imports for Ollama embeddings have been migrated from the @langchain/community package to the newer @langchain/ollama package, ensuring compatibility with the latest library versions.
  • Parameter Name Alignment: The useMMap parameter within the request options has been adjusted to useMmap (lowercase 'm') to align with the naming convention expected by the updated @langchain/ollama library.
  • Node Version Update: The version of the Ollama Embeddings node has been incremented from 1.0 to 2.0 to reflect these significant updates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates the Ollama embedding node to use the newer @langchain/ollama package, which resolves an issue with an incorrect API endpoint. The changes correctly adapt the code to the new library's API, and the component version has been appropriately incremented to reflect this breaking change. I've added one suggestion to improve code conciseness. Also, please note there's a small typo in the PR title and description ('incorrected' should be 'incorrect').

@smartcoder0777 smartcoder0777 changed the title fixed incorrected ollama embedding api endpoint fixed incorrect ollama embedding api endpoint Jan 20, 2026
used changed nullish coalescing operator

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ollama embedding

1 participant