Skip to content

Drop React FAB dependency by replacing ReactAdapter with vanilla component #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Totremont wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Drop React FAB dependency by replacing ReactAdapter with vanilla component #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
3367679
feat: implement chat assistant as pure vaadin component
Totremont Mar 10, 2026
b58d1b6
refactor: remove unused files
Totremont Mar 10, 2026
4b17c35
build: update addon to 5.0.0-SNAPSHOT
Totremont Mar 10, 2026
fc3ceeb
WIP: use this instead of document
Totremont Mar 11, 2026
694cbf8
WIP: use default submit listener
Totremont Mar 11, 2026
e01a391
WIP: use correct unread count
Totremont Mar 11, 2026
07ed4c9
WIP: snap to boundary on resizing
Totremont Mar 11, 2026
f6b6d82
WIP: remove incorrect newHeight declaration
Totremont Mar 11, 2026
3af9691
WIP: add pointer capture targets
Totremont Mar 11, 2026
86df4f2
WIP: drop overlay attribute check
Totremont Mar 11, 2026
367e030
WIP: remove unnecessary comment
Totremont Mar 11, 2026
787c859
WIP: include pointer capture target
Totremont Mar 11, 2026
75ec896
WIP: bring back chat buttons
Totremont Mar 11, 2026
e51c6fc
WIP: adjusts window size when resizing screen
Totremont Mar 11, 2026
96ab550
WIP: center mouse movement in fab
Totremont Mar 11, 2026
ed1383e
WIP: add fc- prefix to message css style
Totremont Mar 11, 2026
3e3e204
WIP: initialize unread count to variable value
Totremont Mar 11, 2026
02a4928
WIP: consider minimum dimensions when shrinking content window
Totremont Mar 11, 2026
8651263
WIP: guard against null server reference
Totremont Mar 11, 2026
f13f050
WIP: guard against invalid pointer capture target
Totremont Mar 11, 2026
44804bd
WIP: remove non existing overlayArrowCenteredAttribute variable usage
Totremont Mar 11, 2026
cea3b16
WIP: drop unnecessary server round trip when refreshing listeners
Totremont Mar 11, 2026
93311ca
WIP: return to previous movement offset
Totremont Mar 11, 2026
38aa323
WIP: implement other mechanism to get popover overlay
Totremont Mar 11, 2026
6d44d6d
WIP: use current width and height when moving fab
Totremont Mar 11, 2026
198081b
WIP: fix license format in styles
Totremont Mar 11, 2026
91728df
build: remove json-migration-helper
Totremont Mar 11, 2026
5fe029f
WIP: fix listener refresh flag
Totremont Mar 11, 2026
521605d
WIP: usage uniqueFlag instead of object reference
Totremont Mar 11, 2026
a6a41e2
WIP: improve pointer event handling
Totremont Mar 12, 2026
fa3dc93
WIP: fix resizers positions
Totremont Mar 12, 2026
2d7ad6a
WIP: combine resizing logic into single file and method
Totremont Mar 12, 2026
15ccb81
WIP: add fabIcon method with configurable size
Totremont Mar 16, 2026
7670c1f
WIP: use refreshContent()
Totremont Mar 16, 2026
6ade2fc
WIP: use lombok getter
Totremont Mar 16, 2026
50c41db
WIP: improve code style
Totremont Mar 16, 2026
c4fe9d4
build : update markdowneditor to 2.0.3 and improve pom
Totremont Mar 16, 2026
04cce36
WIP: improve movement and ui
Totremont Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>org.vaadin.addons.flowingcode</groupId>
<artifactId>chat-assistant-addon</artifactId>
<version>4.0.1-SNAPSHOT</version>
<version>5.0.0-SNAPSHOT</version>
<name>Chat Assistant Add-on</name>
<description>Chat Assistant Add-on for Vaadin Flow</description>

Expand All @@ -16,9 +16,14 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<drivers.dir>${project.basedir}/drivers</drivers.dir>
<webdriver.chrome.driver>${drivers.dir}/chromedriver</webdriver.chrome.driver>
Copy link

@coderabbitai coderabbitai bot Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== webdriver property and setup usage =="
rg -n -C2 'webdriver\.chrome\.driver|WebDriverManager\.chromedriver\(\)\.setup\('

echo
echo "== check whether a local chromedriver binary is actually present in repo =="
fd -HI 'chromedriver(\.exe)?$'

Repository: FlowingCode/ChatAssistant

Length of output: 1415

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Check if test code reads webdriver.chrome.driver system property =="
rg -n 'webdriver\.chrome\.driver|System\.getProperty|WebDriver' src/test --type java -C3

echo
echo "== List what's in drivers directory if it exists =="
if [ -d "drivers" ]; then
  ls -la drivers 2>/dev/null || echo "drivers directory is empty"
else
  echo "drivers directory does not exist"
fi

echo
echo "== Check pom.xml configuration context for Maven Surefire/Failsafe =="
rg -n -B5 -A10 'systemPropertyVariables' pom.xml

Repository: FlowingCode/ChatAssistant

Length of output: 3512

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Check if TestBench reads webdriver.chrome.driver property =="
rg -n 'WebDriver|TestBench' src/test/java/com/flowingcode/vaadin/addons/chatassistant/it/AbstractViewTest.java | head -30

echo
echo "== Look for any DesiredCapabilities or driver initialization that might use the property =="
rg -n 'DesiredCapabilities|RemoteWebDriver|new Chrome|capabilities' src/test --type java

Repository: FlowingCode/ChatAssistant

Length of output: 939

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Check if there are other Maven profiles that might reference webdriver.chrome.driver =="
rg -n 'webdriver\.chrome\.driver|drivers\.dir' pom.xml

echo
echo "== Look at the full profile context where line 415 appears =="
sed -n '390,440p' pom.xml

Repository: FlowingCode/ChatAssistant

Length of output: 2128

Remove unused webdriver.chrome.driver property definitions.

Tests use WebDriverManager.chromedriver().setup() to manage the Chrome driver and create instances with new ChromeDriver(). The property defined at line 19 and passed as a system property at line 415 is never read by test code. Additionally, the drivers directory referenced by this property does not exist in the repository. These lines can be safely removed.

Proposed cleanup 
-		<webdriver.chrome.driver>${drivers.dir}/chromedriver</webdriver.chrome.driver>
-							<systemPropertyVariables>
-								<!-- Pass location of downloaded webdrivers to the tests -->
-								<webdriver.chrome.driver>${webdriver.chrome.driver}</webdriver.chrome.driver>
-							</systemPropertyVariables>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<webdriver.chrome.driver>${drivers.dir}/chromedriver</webdriver.chrome.driver>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@pom.xml` at line 19, Remove the unused Maven properties and system property
usage for the Chrome driver: delete the <webdriver.chrome.driver> property and
the related ${drivers.dir} property reference from the pom (remove the
webdriver.chrome.driver and drivers.dir entries) and also remove any code that
passes -Dwebdriver.chrome.driver=${drivers.dir}/chromedriver to the JVM (e.g.,
in surefire/failsafe or plugin configuration). Target the property named
webdriver.chrome.driver and any references to drivers.dir and the
-Dwebdriver.chrome.driver system property so tests rely solely on
WebDriverManager.chromedriver().setup() and new ChromeDriver().

<jetty.version>11.0.26</jetty.version>
<flowingcode.commons.demo.version>5.2.0</flowingcode.commons.demo.version>
<markdown-editor.version>2.0.1</markdown-editor.version>
<markdown-editor.version>2.0.3</markdown-editor.version>
<lombok.version>1.18.34</lombok.version>
<hamcrest.version>1.3</hamcrest.version>
<servlet-api.version>3.1.0</servlet-api.version>
<webdrivermanager.version>6.1.0</webdrivermanager.version>
<frontend.hotdeploy>true</frontend.hotdeploy>
</properties>

Expand All @@ -31,7 +36,7 @@
<licenses>
<license>
<name>Apache 2</name>
<url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
Expand Down Expand Up @@ -124,16 +129,11 @@
<artifactId>markdown-editor-addon</artifactId>
<version>${markdown-editor.version}</version>
</dependency>
<dependency>
<groupId>com.flowingcode.vaadin</groupId>
<artifactId>json-migration-helper</artifactId>
<version>0.9.2</version>
</dependency>
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<scope>provided</scope>
<version>1.18.34</version>
<version>${lombok.version}</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
Expand All @@ -154,20 +154,20 @@
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-library</artifactId>
<version>1.3</version>
<version>${hamcrest.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>javax.servlet-api</artifactId>
<version>3.1.0</version>
<version>${servlet-api.version}</version>
<type>jar</type>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.github.bonigarcia</groupId>
<artifactId>webdrivermanager</artifactId>
<version>6.1.0</version>
<version>${webdrivermanager.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down Expand Up @@ -241,7 +241,7 @@
<artifactId>jetty-maven-plugin</artifactId>
<version>${jetty.version}</version>
<configuration>
<scanIntervalSeconds>3</scanIntervalSeconds>
<scan>3</scan>
<!-- Use test scope because the UI/demo classes are in the test package. -->
<useTestScope>true</useTestScope>
<webApp>
Expand Down Expand Up @@ -371,7 +371,7 @@
<artifactId>jetty-maven-plugin</artifactId>
<version>${jetty.version}</version>
<configuration>
<scanIntervalSeconds>0</scanIntervalSeconds>
<scan>0</scan>
<supportedPackagings>
<supportedPackaging>jar</supportedPackaging>
</supportedPackagings>
Expand Down Expand Up @@ -412,9 +412,7 @@
<enableAssertions>true</enableAssertions>
<systemPropertyVariables>
<!-- Pass location of downloaded webdrivers to the tests -->
<webdriver.chrome.driver>
${webdriver.chrome.driver}
</webdriver.chrome.driver>
<webdriver.chrome.driver>${webdriver.chrome.driver}</webdriver.chrome.driver>
</systemPropertyVariables>
</configuration>
</plugin>
Expand Down
Loading
Loading