events: serve /events/ from Nuxt - #5785
Conversation
✅ Deploy Preview for flowfuse-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
a087623 to
0107225
Compare
2744669 to
0dbcf8f
Compare
0dbcf8f to
1a227e1
Compare
|
@Yndira-E I recommend we merge this, when @dimitrieh fixed the tests, but then afterwards merge |
1a227e1 to
b2d5a0c
Compare
|
Rebased on The prerender 500 on From the review pass over the whole migration:
On merging |
b2d5a0c to
f940058
Compare
|
Rebased onto |
3 routes move off 11ty. These are three one-off pages on layouts/base.njk, which
added only the header and footer, so each stays its own page with its former
frontmatter as local data.
The three "book a demo" buttons were hand-written ff-btn links to /book-demo and
fired no event; they are <CtaBookDemo> now, so they carry the registry's copy
and tracking. The two in-page jump links used an inline onclick calling
scrollIntoView and go through useScrollToAnchor, the same helper the pages that
included smooth-scroll.njk use.
/events/hannover-messe-2025/ had two <h3>s closed with a stray </span>, and a
heading using </br>, which is not a tag; the markup is well-formed here.
Verified all 3 against production. The only differences are the demo buttons'
label and href, which now come from the CTA registry ("Book a Demo",
uppercased by CSS, and a trailing slash) rather than being typed per page.
f940058 to
0a84cbd
Compare
|
Rebased onto |
|
Nothing to change here, one note. It was flagged on three of these PRs and is actually missing on eight, so it is fixed in one place in #5815 rather than eight conflicting edits to the same file. Merge that one after this, since registering a section before its pages land points dev at a Nuxt route that does not exist yet. |
Without the prefix the dev middleware keeps proxying to 11ty, so npm run dev shows the old page. The middleware returns early unless NODE_ENV is development, which is why CI and the deploy preview both looked correct. The event images and the Hannover .ics stay in src/ and only reach nuxt/public through the 11ty passthrough in a production build, so dev needs the carve-out /resources and /vs already have.
|
Correction to my earlier comment: #5815 is closed, the registration belongs in each migration PR instead. Pushed here. It also carries the carve-out for |
The three glyphs are stock Heroicons, so they go through <UIcon> and SiteArt.vue, siteArt.ts and gen-site-art.mjs come out. Each call site carries its own size: UIcon renders a mask span with no intrinsic ratio, so a width-only wrapper would have collapsed it. Both anchors already carry the href they scrolled to, so the handler only had to preventDefault to do what the browser does anyway. The site-wide scroll-behavior: smooth animates the jump, which retires the composable.
|
Took the cross-PR pass over the four patterns here. Three of them applied:
Leftover 11ty layouts: none here. Checked which layouts this branch makes dead relative to main rather than which are dead on it, since Worth a look on the preview: |
# Conflicts: # nuxt/nuxt.config.ts # nuxt/server/middleware/legacy.ts
|
Conflicts resolved, main is merged in. Same shape as the other migration PRs: the registry files take the union, so |
# Conflicts: # nuxt/server/middleware/legacy.ts
# Conflicts: # nuxt/nuxt.config.ts # nuxt/server/middleware/legacy.ts
# Conflicts: # nuxt/nuxt.config.ts
2 participants
Description
Moves
/events/to Nuxt: ProveIt 2026 and both Hannover Messe pages.Their art is now a tracked asset rather than something Eleventy copied at build time.
Related Issue(s)
Part of #5777
Checklist