vs: serve /vs/ from Nuxt - #5783
Merged
Merged
Conversation
✅ Deploy Preview for flowforge-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dimitrieh
force-pushed
the
nuxt/vs
branch
2 times, most recently
from
September 11, 2026 17:49
7432ef0 to
4797423
Compare
ZJvandeWeg
reviewed
Sep 11, 2026
ZJvandeWeg
reviewed
Sep 11, 2026
ZJvandeWeg
reviewed
Sep 14, 2026
Member
|
@JoycePlaysFootball @Yndira-E I think we can remove the current |
3 routes move off 11ty. The pages were near-identical - the same seven sections with a different competitor in them - so they become one data collection and one renderer rather than three copies of the same template. The competitor's comparison column was keyed by its own name in each file (item.ignition, item.Kepware, item.litmus); it is `competitor` in all three now so one renderer reads them. `sectionSubtitle` was in all three frontmatters and read by none, and switch.cta/ctaUrl were carried but never rendered; both are dropped. /vs/kepware/ had drifted from the other two: no comparison chip, no "at a Glance" heading, an unbordered table, plain section icons rather than accent badges, a plain closing card, and the default social-proof eyebrow. It follows the same structure as the other two now. That is a visible change to that page, made deliberately. nuxt/lib/rich-text.mjs is now a small allowlist sanitiser rather than three hard-coded tag replacements, because this content needs <code>, inline links and font-weight spans as well. It escapes the string, then re-enables a fixed set of inline tags; `class` survives only if every token is a typography utility, and `href` only if it is site-absolute or https. Any other tag, attribute, class or scheme stays visible text. Tested, including the rejections. Verified all 3 against production. /vs/ignition/ and /vs/litmus/ match exactly; /vs/kepware/ differs by the three headings the unification adds.
Contributor
Author
|
Rebased on
From the review pass over the whole migration:
On removing the |
Yndira-E
reviewed
Sep 14, 2026
Co-authored-by: Yndira Escobar <129537638+Yndira-E@users.noreply.github.com>
Contributor
|
These vs. pages are poorly written. We will start fresh. I'll merge this PR. |
dimitrieh
added a commit
that referenced
this pull request
Sep 16, 2026
Marketing retired Aerospace Components, Aviation & Aerospace, Electronics & Appliances, Renewables, Semiconductors, Food & Beverage and Life Sciences. /industries/automotive/ stays. All seven were live and indexed, so the URLs 301 to /industries/ rather than 404ing. Their content, the [slug].vue route that served them, the seven components/industry/ bands, the `industries` collection and its schema, the sitemap and prerender entries and ~40 images all go with them, since the seven .yml files were their only consumers. The header dropdown and the footer group lose the same seven links, so nothing in the chrome points at a redirect. navIcons keeps two of the keys this branch added: /vs/kepware/ and /vs/litmus/ name `arrows-pointing-out` and `link` in content merged with #5783, but neither was ever added to the registry, so NavIcon renders nothing for them on main today. Both pages show one icon fewer than /vs/ignition/ on live. components/use-case/Card.vue goes back to #5780, which adds the same file and is the only branch still using it.
dimitrieh
added a commit
that referenced
this pull request
Sep 16, 2026
The .njk's extraClass came over verbatim, but it was written against a different DOM. cta-button.njk wrapped the label and the arrow in one <span class="inline-flex items-center gap-2">, so the <a> had a single child and `inline` / `flex flex-col` changed nothing that was drawn. UButton renders the label and its trailing-icon as siblings, so `flex flex-col` stacks them and `inline` drops the flex context that centres the arrow. Dropping the two classes restores UButton's own inline-flex; the mobile CTA keeps w-full and its margins. pages/vs/[slug].vue carries the same string from #5783 and is already on main, so /vs/ignition/, /vs/kepware/ and /vs/litmus/ stack their mobile CTA on live today. Same one-line fix, included here because it is the same root cause.
dimitrieh
added a commit
that referenced
this pull request
Sep 16, 2026
Marketing retired Aerospace Components, Aviation & Aerospace, Electronics & Appliances, Renewables, Semiconductors, Food & Beverage and Life Sciences. /industries/automotive/ stays. All seven were live and indexed, so the URLs 301 to /industries/ rather than 404ing. Their content, the [slug].vue route that served them, the seven components/industry/ bands, the `industries` collection and its schema, the sitemap and prerender entries and ~40 images all go with them, since the seven .yml files were their only consumers. The header dropdown and the footer group lose the same seven links, so nothing in the chrome points at a redirect. navIcons keeps two of the keys this branch added: /vs/kepware/ and /vs/litmus/ name `arrows-pointing-out` and `link` in content merged with #5783, but neither was ever added to the registry, so NavIcon renders nothing for them on main today. Both pages show one icon fewer than /vs/ignition/ on live. components/use-case/Card.vue goes back to #5780, which adds the same file and is the only branch still using it.
2 of 5 tasks
2 of 5 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves
/vs/to Nuxt. The comparison pages were frontmatter read by one layout, so they become a content collection and a single[slug].vue.Related Issue(s)
Part of #5777
Checklist