Skip to content

[2068] Service worker prevents auth redirect when dashboard is behind an authentication proxy #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n-lark wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −23
Open

[2068] Service worker prevents auth redirect when dashboard is behind an authentication proxy #2213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2847ec1
Add navigationRoute that allows for auth redirects with offline fallback
n-lark Sep 8, 2026
dfa3000
Skip precaching in dev builds so the service worker doesn't serve sta…
n-lark Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 19 additions & 22 deletions ui/src/sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,31 @@
/// <reference lib="webworker" />
import { clientsClaim } from 'workbox-core'
import { cleanupOutdatedCaches, createHandlerBoundToURL, precacheAndRoute } from 'workbox-precaching'
import { cleanupOutdatedCaches, matchPrecache, precacheAndRoute } from 'workbox-precaching'
import { NavigationRoute, registerRoute } from 'workbox-routing'

// self.__WB_MANIFEST is the default injection point
precacheAndRoute(self.__WB_MANIFEST)
// directoryIndex/cleanURLs off so the precache doesn't serve a /dashboard/ navigation from cache - the route below owns navigations
precacheAndRoute(self.__WB_MANIFEST, {
directoryIndex: null,
cleanURLs: false
})

// clean old assets
cleanupOutdatedCaches()

/** @type {RegExp[] | undefined} */
const denylist = []
const NETWORK_TIMEOUT_MS = 5000

// in dev mode, do not precache anything
if (import.meta.env.DEV) {
// don't precache anything
console.log('Development mode, not pre-caching anything')
denylist.push(/.*/)
} else {
// don't precache anything where the urls pathname ends with a slash (including times when the url has a query string)
// this permits the request to be handled by the server which will do a redirect as required
const configPath = self.location.pathname.split('/')[1]
denylist.push(new RegExp(`/${configPath}/[^?]*/(\\?.*)*$`))
}

// to allow work offline for allowed routes only
registerRoute(new NavigationRoute(
createHandlerBoundToURL('index.html'),
{ denylist }
))
// Network-first so an auth proxy's login redirect is followed - cached shell as offline fallback
registerRoute(new NavigationRoute(async ({ request }) => {
const controller = new AbortController()
const timeout = setTimeout(() => controller.abort(), NETWORK_TIMEOUT_MS)
try {
return await fetch(request, { signal: controller.signal })
} catch {
return (await matchPrecache('index.html')) || Response.error()
} finally {
clearTimeout(timeout)
}
}))

self.skipWaiting()
// https://developer.mozilla.org/en-US/docs/Web/API/Clients/claim
Expand Down
2 changes: 1 addition & 1 deletion vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default defineConfig({

injectManifest: {
maximumFileSizeToCacheInBytes: process.env.NODE_ENV === 'development' ? 6000000 : 3350000,
globPatterns: ['**/*.{js,css,html,svg,png,ico,ttf,eot,woff,woff2}']
globPatterns: process.env.NODE_ENV === 'development' ? [] : ['**/*.{js,css,html,svg,png,ico,ttf,eot,woff,woff2}']
},

devOptions: {
Expand Down
Loading