Skip to content

feat: Use NodeJS v24 as a default version across all reusable workflows#96

Merged
hardillb merged 3 commits intomainfrom
ci-node-24-as-default-gha-runtime
Mar 24, 2026
Merged

feat: Use NodeJS v24 as a default version across all reusable workflows#96
hardillb merged 3 commits intomainfrom
ci-node-24-as-default-gha-runtime

Conversation

@ppawlowski
Copy link
Collaborator

Description

This pull request configures NodeJS v24 as a default runtime for every reusable GitHub Actions workflow.

Related Issue(s)

https://github.com/FlowFuse/CloudProject/issues/1180

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb March 23, 2026 17:22
strategy:
matrix:
node-version: [20.x]
node: ${{ fromJson(inputs.node)}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is fromJson defined?

because assuming it's parsing [{"version": "24", "tests": true, "lint": true}] it needs to output [ 24 ]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#fromjson

It outputs a node object with version, tests and lint keys .

Copy link
Collaborator Author

@ppawlowski ppawlowski Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See how it works in the Build and test npm package reusable workflow

@ppawlowski ppawlowski requested a review from hardillb March 24, 2026 15:18
@hardillb hardillb merged commit 52b4dab into main Mar 24, 2026
@hardillb hardillb deleted the ci-node-24-as-default-gha-runtime branch March 24, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants