Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4d41fa5
Publish application lifecycle events over the team channel
n-lark Jul 31, 2026
8469acb
Centralize team applications in a data-farm store, migrate the list +…
n-lark Jul 31, 2026
ee86ccc
Merge branch 'main' into 7651-df-applications-store
n-lark Aug 3, 2026
f241f06
Merge branch 'main' into 7651-df-applications-store
hardillb Aug 3, 2026
da9223f
Add applications subscriber and connect to pinia store with specs
n-lark Aug 3, 2026
be80d67
Update app.orchestrator spec
n-lark Aug 3, 2026
815f590
Migrate single-application views to the data-farm store, remove the A…
n-lark Aug 3, 2026
ea59d77
Drive single-application view loaders off the store's isLoadingActive…
n-lark Aug 3, 2026
e7635c4
Update import paths to fix cypress
n-lark Aug 3, 2026
f2444d3
Merge remote-tracking branch 'origin/main' into 7652-df-applications-sub
n-lark Aug 3, 2026
5d4047b
Merge branch 'main' into 7652-df-applications-sub
n-lark Aug 4, 2026
fd0f68e
Merge branch '7652-df-applications-sub' into 7839-df-applications-loa…
n-lark Aug 4, 2026
baff075
Merge remote-tracking branch 'origin/main' into 7839-df-applications-…
n-lark Aug 4, 2026
0d105ef
Merge branch 'main' into 7839-df-applications-loaders
n-lark Aug 4, 2026
1a23c3d
Fix issues with null check for applicatios and stuck on loader for de…
n-lark Aug 5, 2026
04dd47f
[8053] Data Farm > Applications 5 - UXStore Page Loader (#8063)
n-lark Aug 7, 2026
43f50b0
Merge remote-tracking branch 'origin/main' into 7839-df-applications-…
n-lark Aug 7, 2026
2785d4e
Merge remote-tracking branch 'origin/main' into 7839-df-applications-…
n-lark Aug 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions frontend/src/components/SkeletonBlock.vue

This file was deleted.

27 changes: 27 additions & 0 deletions frontend/src/composables/useActiveApplication.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { useRouter } from 'vue-router'

import { useDataFarmApplicationsStore } from '@/stores/data-farm-applications'
import type { ApplicationSummary } from '@/types'

export function useActiveApplication () {
const router = useRouter()
const applicationsStore = useDataFarmApplicationsStore()

async function loadActiveApplication (id: string): Promise<ApplicationSummary | null> {
if (!id) return null
try {
return await applicationsStore.loadActiveApplication(id)
} catch {
const current = router.currentRoute.value
router.push({
name: 'page-not-found',
params: { pathMatch: current.path.substring(1).split('/') },
query: current.query,
hash: current.hash
})
return null
}
}

return { loadActiveApplication }
}
16 changes: 12 additions & 4 deletions frontend/src/layouts/Page.vue
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
<template>
<slot name="header" />
<main :class="mainClasses">
<slot name="default" />
</main>
<div v-if="!pageLoader" class="flex flex-col flex-1 w-full min-h-0">
<slot name="header" />
<main :class="mainClasses">
<slot name="default" />
</main>
</div>
<ff-loading v-else :message="pageLoaderMessage" />
</template>

<script>
import { mapState } from 'pinia'

import { useUxLoadingStore } from '@/stores/ux-loading.js'

export default {
name: 'PageLayout',
props: {
Expand All @@ -15,6 +22,7 @@ export default {
}
},
computed: {
...mapState(useUxLoadingStore, ['pageLoader', 'pageLoaderMessage']),
mainClasses () {
const classes = ['flex-1', 'overflow-auto', 'h-full', 'w-full', 'flex', 'flex-col']
if (!this.noPadding && !this.hasRouteDeclaredNoPadding) {
Expand Down
118 changes: 0 additions & 118 deletions frontend/src/mixins/Application.js

This file was deleted.

23 changes: 17 additions & 6 deletions frontend/src/pages/application/CreateInstanceMultiStep.vue
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<ff-loading v-if="isLoading" />

<MultiStepInstanceForm
v-else
v-else-if="application"
ref="multiStepForm" :application="application" @instance-created="onInstanceCreated"
@previous-step-state-changed="form.previousButtonState = $event"
@next-step-state-changed="form.nextButtonState = $event"
Expand All @@ -40,24 +40,30 @@
</template>

<script>
import { mapState } from 'pinia'
import { mapActions, mapState } from 'pinia'

import MultiStepInstanceForm from '../../components/multi-step-forms/instance/MultiStepInstanceForm.vue'

import { getTeamProperty } from '../../composables/TeamProperties.js'
import applicationMixin from '../../mixins/Application.js'

import { useActiveApplication } from '../../composables/useActiveApplication'

import { useAccountSettingsStore } from '@/stores/account-settings.js'
import { useContextStore } from '@/stores/context.js'
import { useDataFarmApplicationsStore } from '@/stores/data-farm-applications'

export default {
name: 'ApplicationCreateInstance',
components: {
MultiStepInstanceForm
},
mixins: [applicationMixin],
inheritAttrs: false,
emits: ['application-updated'],
setup () {
const { loadActiveApplication } = useActiveApplication()

return { loadActiveApplication }
},
data () {
return {
loading: false,
Expand All @@ -74,8 +80,9 @@ export default {
computed: {
...mapState(useContextStore, ['team']),
...mapState(useAccountSettingsStore, ['features']),
...mapState(useDataFarmApplicationsStore, { application: 'activeApplication', applicationHydrated: 'applicationHydrated' }),
isLoading () {
return this.loading || !this.team
return this.loading || !this.team || !this.applicationHydrated
}
},
async created () {
Expand Down Expand Up @@ -107,9 +114,13 @@ export default {
})
}

await this.updateApplication()
await this.loadActiveApplication(this.$route.params.id)
},
beforeUnmount () {
this.clearActiveApplication()
},
methods: {
...mapActions(useDataFarmApplicationsStore, ['clearActiveApplication']),
async onInstanceCreated () {
await useContextStore().refreshTeam()

Expand Down
22 changes: 16 additions & 6 deletions frontend/src/pages/application/createInstance.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<ff-page-header title="Instances">
<template #custom-breadcrumbs>
<ff-nav-breadcrumb v-if="team" :to="{name: 'team-applications', params: {team_slug: team.slug}}">Applications</ff-nav-breadcrumb>
<ff-nav-breadcrumb v-if="team" :to="{name: 'Application', params: {id: application.id}}">
<ff-nav-breadcrumb v-if="team && application" :to="{name: 'Application', params: {id: application.id}}">
{{ application.name }}
</ff-nav-breadcrumb>
<ff-nav-breadcrumb>
Expand Down Expand Up @@ -36,23 +36,23 @@

<script>
import { ChevronLeftIcon } from '@heroicons/vue/20/solid/index.js'
import { mapState } from 'pinia'
import { mapActions, mapState } from 'pinia'

import instanceApi from '../../api/instances.js'

import applicationMixin from '../../mixins/Application.js'
import { useActiveApplication } from '../../composables/useActiveApplication'
import Alerts from '../../services/alerts.js'
import InstanceForm from '../instance/components/InstanceForm.vue'

import { useAccountSettingsStore } from '@/stores/account-settings.js'
import { useContextStore } from '@/stores/context.js'
import { useDataFarmApplicationsStore } from '@/stores/data-farm-applications'

export default {
name: 'ApplicationCreateInstance',
components: {
InstanceForm
},
mixins: [applicationMixin],
inheritAttrs: false,
props: {
sourceInstanceId: {
Expand All @@ -61,6 +61,11 @@ export default {
}
},
emits: ['application-updated'],
setup () {
const { loadActiveApplication } = useActiveApplication()

return { loadActiveApplication }
},
data () {
return {
icons: {
Expand All @@ -78,12 +83,13 @@ export default {
computed: {
...mapState(useContextStore, ['team']),
...mapState(useAccountSettingsStore, ['features']),
...mapState(useDataFarmApplicationsStore, { application: 'activeApplication', applicationHydrated: 'applicationHydrated' }),
isLoading () {
return this.loading || !this.team
return this.loading || !this.team || !this.applicationHydrated
}
},
async created () {
await this.updateApplication()
await this.loadActiveApplication(this.$route.params.id)

if (this.sourceInstanceId) {
instanceApi.getInstance(this.sourceInstanceId).then(instance => {
Expand All @@ -96,7 +102,11 @@ export default {
async mounted () {
this.mounted = true
},
beforeUnmount () {
this.clearActiveApplication()
},
methods: {
...mapActions(useDataFarmApplicationsStore, ['clearActiveApplication']),
async handleFormSubmit (formData, copyParts) {
this.loading = true

Expand Down
Loading
Loading