Skip to content

Store device nodejs version#7577

Merged
knolleary merged 3 commits into
mainfrom
store-device-nodejs-version
Jun 23, 2026
Merged

Store device nodejs version#7577
knolleary merged 3 commits into
mainfrom
store-device-nodejs-version

Conversation

@hardillb

Copy link
Copy Markdown
Contributor

fixes #7551

Description

Adds nodejsVersion to Device table

Uses this to pick the correct default snapshot Node-RED version

paired with FlowFuse/device-agent#657

Related Issue(s)

#7551

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

hardillb added 3 commits June 22, 2026 10:02
fixes #7551

Also change default Node-RED version based on NodeJS version
@hardillb hardillb requested a review from knolleary June 22, 2026 10:04
@hardillb hardillb self-assigned this Jun 22, 2026
@hardillb hardillb added area:remote-instance Work related to remote instances area:migration Involves a database migration labels Jun 22, 2026
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.95%. Comparing base (fab5b55) to head (ca89146).

Files with missing lines Patch % Lines
forge/db/controllers/Device.js 50.00% 1 Missing ⚠️
...db/migrations/20260622-01-add-device-nodejs-ver.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7577   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files         410      411    +1     
  Lines       21002    21012   +10     
  Branches     5117     5120    +3     
=======================================
+ Hits        16162    16170    +8     
- Misses       4840     4842    +2     
Flag Coverage Δ
backend 76.95% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hardillb

Copy link
Copy Markdown
Contributor Author

WARNING

PR with db migration, need to check which is merged first
#7580

@knolleary knolleary merged commit 14c3010 into main Jun 23, 2026
29 checks passed
@knolleary knolleary deleted the store-device-nodejs-version branch June 23, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:migration Involves a database migration area:remote-instance Work related to remote instances

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store node.js version of remote instances

2 participants