[6942] Pinia Task 13 - account-team #6952
Draft
n-lark wants to merge 4 commits into6829-pinia-task-12-account-authfrom
Draft
[6942] Pinia Task 13 - account-team #6952n-lark wants to merge 4 commits into6829-pinia-task-12-account-authfrom
n-lark wants to merge 4 commits into6829-pinia-task-12-account-authfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 6829-pinia-task-12-account-auth #6952 +/- ##
================================================================
Coverage 76.29% 76.29%
================================================================
Files 403 403
Lines 20293 20293
Branches 4880 4880
================================================================
Hits 15482 15482
Misses 4811 4811
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… into 6942-pinia-task-13-account-team
…nitial notifications state
n-lark
commented
Mar 25, 2026
| // Same team — skip full reload but always refresh membership | ||
| if (team?.id) { | ||
| this.teamMembership = await teamApi.getTeamUserMembership(team.id) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
With pinia-plugin-persistedstate, the store hydrates from sessionStorage synchronously on first access. So this.team is already set when checkState calls setTeam. This meant currentTeam?.id === team?.id was always true on second+ page loads, the early return fired, and getTeamUserMembership was never called.
Fix: when IDs match, still call getTeamUserMembership before returning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See details & test plan.
Related Issue(s)
Resolves #6942
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel