Conversation
Prevents issue with shade from snapshot drawer
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6892 +/- ##
=======================================
Coverage 76.63% 76.63%
=======================================
Files 399 399
Lines 20167 20167
Branches 4856 4856
=======================================
Hits 15454 15454
Misses 4713 4713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Steve-Mcl do I argue correctly here if this still needs review and the points adjusted from the slack conv? https://flowfuse.slack.com/archives/C09QS57R8AD/p1773865648690409 |
@dimitrieh I missed the issue about not re-opneing for you in the slack thread. Transferring that here: From Slack/Dimitrie
In short, it works for me: Did you have and errors in console? |


Description
Persistent pinning and open state of the FF Expert
NOTES
Subtle issue: We dont have a layered tray system like Node-RED so when expert is pinned open & user opens the notifications or a snapshot, the drawer (expert) is closed and the drawer re-opened with the new content/component. That means user would need to click Expert button to re-open it after dismissing the notification tray/snapshot tray.
So... I have added workaround - it will re-open the Expert if it was previously PINNED and OPEN (at the point in time that the notifications/snapshot was drawer was opened)
IMO - It looks a bit janky - please check it out on pre-staging (i'll post a link once its built)
There may be a way to improve this (drawer component reuse) however I suspect it is quite a large refactor due to single state
Persistent expert drawer state and session management:
expertStateobject torightDrawerinuseUxDrawersStore, tracking whether the expert drawer is pinned and open, and configured it to be stored inlocalStoragefor session persistence. [1] [2]expertStatewhenever the expert drawer is opened, closed, or pinned, ensuring consistent behavior and state across user actions and sessions. [1] [2] [3]Drawer transition and animation improvements:
RightDrawer.vue, including improved handling for opening the expert drawer in pinned mode and preventing unnecessary animations when pinning. [1] [2] [3]Drawer interaction and open logic:
openAssistantDrawer) to accept anopenPinnedoption, allowing the drawer to open in pinned mode and controlling whether it closes on click outside. [1] [2]Codebase integration:
RightDrawer.vuefor consistent state management and action dispatching. [1] [2]Related Issue(s)
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel