Allow snapshot to be restored to a remote instance in dev mode#6679
Allow snapshot to be restored to a remote instance in dev mode#6679
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6679 +/- ##
==========================================
- Coverage 76.66% 76.65% -0.01%
==========================================
Files 398 398
Lines 20103 20108 +5
Branches 4841 4844 +3
==========================================
+ Hits 15411 15414 +3
- Misses 4692 4694 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Steve-Mcl
left a comment
There was a problem hiding this comment.
1 issue, 1 nitpick
Issue:
After deploying a snapshot something is not being refreshed locally preventing previously applied snapshot being deployed (even though my very last action was to deploy a different snapshot)
To repicate ^
- Make snapshot 1
- Alter flows
- Make snapshot 2
- Refresh FF
- Restore snapshot 1 ✅
- Restore snapshot 2 ❌
After refreshing the FF app, it is permitted to be deployed.
Nitpick
It is not obvious that work could be lost from the modal.
Can we make this clear like the dev mode toggle?
I think this is a timing issue. You are deploying snapshot 1, then fairly quickly asking to restore snapshot 2 - however the device is still updating to snapshot1 and has not yet reported back that it's running snapshot1 - so the platform thinks its active snapshot is still snapshot 2. I'll try to reproduce, but with a longer delay between the restores to see if that theory is correct. If so, I think we can live with it. |
I dont think so unfortunately. I took that gif about 20 mins ago then left it running. It still happens. I had to refresh FF page then I could deploy EDIT it is hard to tell from the GIF (since its a loop) but whats happening is:
|
@Steve-Mcl ready for another review |
Steve-Mcl
left a comment
There was a problem hiding this comment.
Working well locally. Tested before and after merging main (with the new immersive experience)



Closes #6654
This adds a
forceUpdateflag to the status update sent to a device when changing the snapshot version manually (ie, not via a pipeline).When running a device with FlowFuse/device-agent#570 applied, this will allow the snapshot to be applied even if in developer mode.
In the UI:
canDeploylogic that determines if the snapshot restore button is enabled so that if the device is in dev mode, but is running 3.8.0 (as yet unreleased), then the button should be enabled