POL-04B: wire unified guide setup to Celery and replace old inference paths - #393
Draft
Abiorh001 wants to merge 24 commits into
Draft
POL-04B: wire unified guide setup to Celery and replace old inference paths#393Abiorh001 wants to merge 24 commits into
Abiorh001 wants to merge 24 commits into
Conversation
added 11 commits
September 9, 2026 20:22
|
Important Review skippedToo many files! This PR contains 145 files, which is 45 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (145)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
added 9 commits
September 9, 2026 23:02
…live-cutover # Conflicts: # .ci/auth-boundaries/TEST_STRUCTURE_DEBT.json # .ci/behavior-ownership/partition.v1.json # backend/alembic/env.py # backend/scripts/behavior_ownership.py # backend/tests/authorization/contribution_policies/test_migration.py # backend/tests/authorization/guide_compilation/test_migration_contract.py # backend/tests/conftest.py # backend/tests/projects/guide_compilation/test_automatic_request.py # backend/tests/projects/guide_compilation/test_migration_authorized_persistence.py # backend/tests/projects/guide_compilation/test_migration_contract.py # backend/tests/projects/guide_compilation/test_projection_migration.py # backend/tests/test_alembic.py # backend/tests/test_behavior_ownership.py
Abiorh001
changed the title
abiorh-claw
self-requested a review
September 9, 2026 23:57
Abiorh001
marked this pull request as ready for review
September 10, 2026 00:20
Abiorh001
marked this pull request as draft
September 10, 2026 05:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Verified guide material now triggers one authorized compilation through Celery. It produces sufficiency findings and distinct pre-submission and post-submission draft policy proposals, then stops. Insufficient guides stop at findings. Replay does not start another provider invocation.
POL-04B change record records intent, scope, decisions, replacement tests and remaining boundaries. Its adopted planning link is preserved.
Verification and review
Real model inference has not been verified. Automated tests use controlled agent/provider responses. The HTTP/PostgreSQL/MinIO evidence proves integration and lifecycle behavior, not a successful external model request or proposal quality. No provider API key is configured in the current execution environment. A live provider smoke test remains outstanding. The user has scheduled this immediately after the current PR, using
.envconfiguration, before further manager-review implementation.Current reviewable head:
98f9c416, reconciled with mainc69ff853(#394). The merge preserves main's API-drill coverage and bounded authority-envelope/traceback repairs. Runtime configuration migration0015_guide_runtime_configurationfollows main's project-role migration.The preceding reviewed head passed 5,870 tests with 92.02% coverage. The focused correction now preserves known SDK parser rejection as
compilation_invalid_terminalrather than an unresolved provider outcome. It translates only the SDK error with a validation-error cause; unrelated failures retain the existing uncertainty fence. The installed parser is exercised for valid JSON, malformed JSON, schema-invalid values and unsafe text. Three real PostgreSQL cases prove exact persisted failure codes and replay without another invocation. Removing the translation makes all three negative parser cases fail while valid JSON still passes.backend/.env.examplenow uses current independent runtime/model/instruction settings, removes obsolete configuration names, and explainsuv run --env-file .envfor both API and worker credentials. No real credential was added. Focused tests pass: 40 adapter cases and four PostgreSQL cases with cleanup complete. Fresh Backend 34440212292 and Agent Gates 34440212323 are pending.Focused proof covers immutable configuration, authorization, same-attempt replay, scan-to-lock recovery races, and exclusion of invalid, uncertain and finalized generations across all four queue representations. Removing only the finalized guard made its real PostgreSQL test fail at the intended assertion. The corrected concurrent human replay test passes with all concurrency assertions intact. Static boundary mutants cover imported, assigned and typed aliases. No coverage floor, skip rule, lane completeness check or failure propagation was weakened.
Focused reviewer replay is in progress for this repair; previous-head results are historical until rebound. The final documentation correction reconciles two stale lifecycle-scoreboard rows with the current cutover and remaining work. Architecture retains one documented low risk: the bounded Celery delivery result is an untyped dictionary. Fresh CI-integrity custody is pending.
The PR is ready for human review. External CodeRabbit review is not fresh: it skipped the final head because 142 files exceed its 100-file limit and review capacity is unavailable. No review threads are open. A green skipped status is not substantive review.
Human review focus
Review fixed-service authority, immutable configuration and evidence, same-attempt recovery without reinference, both distinct phase proposals, and physical removal of superseded paths. The large deletion is intentional and belongs to this single live-path cutover. No retained data is deleted. Eligible human approval and an explicit decision to merge this PR remain required.