Fix LF/CRLF issue of Firefox's profiles.ini

[VictoriousRaptor]

Fixes #4642. Tested on BOTH CRLF/LF.

---

Summary by cubic

Summary of changes

• Fixes Firefox bookmark loading failing when profiles.ini uses LF or CR line endings instead of CRLF; the split in FirefoxBookmarkLoader.cs now handles all three line ending types, resolving issue BUG: Browser Bookmarks: Firefox bookmarks disappear when profiles.ini uses LF line endings (Firefox 155) #4642.
• Replaced the single "\r\n" delimiter with an array of "\r\n", "\r", and "\n"; no other logic removed.
• A UTF-8 BOM was added to the top of the file on save; no functional impact.
• Memory usage impact is negligible since the line array is per-file and small.
• No security risk introduced.
• No automated unit tests added; manually tested on both CRLF and LF files.

Release Note

• Fixes Firefox bookmark loading when profiles.ini uses different line endings.

^{Written for commit e8bc78c. Summary will update on new commits.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a244b94a-6f5f-4a3a-af05-3add02948846

📥 Commits

Reviewing files that changed from the base of the PR and between c587eed and e8bc78c.

📒 Files selected for processing (1)

• Plugins/Flow.Launcher.Plugin.BrowserBookmark/FirefoxBookmarkLoader.cs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The Firefox bookmark loader now parses profiles.ini files with Windows, Unix, and old-Mac line endings. The file also includes a UTF-8 byte-order mark.

Changes

Firefox profile compatibility

Layer / File(s)	Summary
Profile configuration parsing Plugins/Flow.Launcher.Plugin.BrowserBookmark/FirefoxBookmarkLoader.cs	GetProfileIniPath now supports CRLF, CR, and LF line endings when parsing profiles.ini. The file also gains a UTF-8 byte-order mark.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to e8bc7

Firefox bookmark loading now supports profiles.ini files using CRLF, CR, or LF line endings, preventing valid Firefox bookmark profiles from being skipped. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: fixing Firefox profiles.ini parsing for LF and CRLF line endings.
Description check	✅ Passed	The description directly explains the line-ending parsing fix, references issue #4642, and documents testing with CRLF and LF files.
Linked Issues check	✅ Passed	The change satisfies the linked issue objectives [#4642] by parsing CRLF, CR, and LF line endings so valid Firefox profiles resolve and bookmarks remain available.
Out of Scope Changes check	✅ Passed	The code changes are limited to Firefox profiles.ini line-ending parsing. The added UTF-8 BOM is incidental and has no functional impact.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-firefox-lf

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

No issues found across 1 file

_{Re-trigger cubic}