Raise PropertyChanged when ResultViewModel image properties are set

[TrueCrimeDev]

Problem

ResultViewModel.Image, BadgeImage, and PreviewImage never raise PropertyChanged when set. LoadImageAsync awaits the image load and then assigns the property, and its comment states that "modifying the property" triggers the change notification — but the setters are plain field assignments:

private set => _image = value;

Root cause

The notification was lost in e8691c2 (May 2021, "No need for the wrapped Lazy instance in image loading"), which inlined the LazyAsync<ImageSource> wrapper. That wrapper's updateCallback was what called OnPropertyChanged(nameof(Image)); when it was removed, nothing replaced it.

Why it usually doesn't show

A repeat lookup of the same IcoPath hits ImageCache synchronously inside the getter, so the binding already sees the real image the first time it evaluates. The bug only surfaces when a brand-new IcoPath arrives and the host doesn't virtualize the row out and back in — e.g. a single-result query such as a chat plugin's "Ask" preview. There the field is mutated after the await, the binding is never re-evaluated, and the row stays on LoadingImage indefinitely.

Fix

Raise OnPropertyChanged() in all three image setters. ResultViewModel already derives from BaseModel, so no other plumbing is needed.

Testing

• dotnet build Flow.Launcher.sln -c Release — 0 errors
• dotnet test -c Release — 433 passed

ImageLoaderTests.ShellThumbnailFailure_Directory_ReturnsDefaultFolderImageAsync fails on the first run against a fresh build output on my machine, but it fails identically on unmodified dev, so it is unrelated to this change.

---

Summary by cubic

Summary of changes

Ensures ResultViewModel image properties notify bindings after async loads so icons refresh. Previously, Image, BadgeImage, and PreviewImage setters did not raise PropertyChanged, so some results stayed on LoadingImage.

• Changed: Added OnPropertyChanged() in the setters for Image, BadgeImage, and PreviewImage, restoring behavior lost when the LazyAsync<ImageSource> wrapper was removed.
• Added: Bindings now re-evaluate when the image finishes loading; no public API changes.
• Removed: No logic removed.
• Memory impact: None beyond an extra method call per property set; no new allocations.
• Security risks: None.
• Unit tests: No new tests. Existing suite passes locally (433 tests). One known unrelated thumbnail test is flaky on a fresh build in both this branch and dev.

Release Note

Fixes an issue where some result icons stayed stuck on the loading image by updating them automatically once the icon finishes loading.

^{Written for commit 4ee56ab. Summary will update on new commits.}

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

No issues found across 1 file

_{Re-trigger cubic}