Fixed bug class across various Flow-IPC modules wherein the formally-allowed (and perfectly practical) Logger* logger_ptr = nullptr API arg value would result in a crash. (This was ready in a coming-soon release, but new unit-testing for the ongoing borrow_object() hardening, preceding that release, tickles it. Hence backporting the straightforward fix, though it is unrelated to the substance of the aforementioned hardening effort.)#42
Open
Fixed bug class across various Flow-IPC modules wherein the formally-allowed (and perfectly practical) Logger* logger_ptr = nullptr API arg value would result in a crash. (This was ready in a coming-soon release, but new unit-testing for the ongoing borrow_object() hardening, preceding that release, tickles it. Hence backporting the straightforward fix, though it is unrelated to the substance of the aforementioned hardening effort.)#42
Logger* logger_ptr = nullptr API arg value would result in a crash. (This was ready in a coming-soon release, but new unit-testing for the ongoing borrow_object() hardening, preceding that release, tickles it. Hence backporting the straightforward fix, though it is unrelated to the substance of the aforementioned hardening effort.)#42Conversation
…allowed (and perfectly practical) `Logger* logger_ptr = nullptr` API arg value would result in a crash. (This was ready in a coming-soon release, but for the ongoing `borrow_object()` hardening preceding that release the new unit test tickles it. Hence backporting the straightforward fix, though it is unrelated to the substance of the aforementioned hardening effort.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.