xHCI - Check if command ring is full before enqueueing command #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
It's fine in this case since I manually checked out the pr branch and tested it in my build, but in the future, it would be preferred for anyone contributing to do their fair share of testing, and with USB stuff it's tricky, but running it with the GUI would be a preferred way to test the functionality to make sure it still works. Nevertheless, this is a great fix and much appreciated! Merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From FlareCoding/stellux-xhci-tutorial#4 (comment)
I ran the VM (headless), but I did not notice any difference with this change. So it works in theory.